drivers/media/IR/imon.c: Use pr_err instead of err
in [Kernel]
|
Prev: scsi: megaraid_sas - Online Controller Reset - I: Enable Online Controller Reset Bit in register related functions
Next: Add support for the Ingenic JZ4740 System-on-a-Chip
From: Jarod Wilson on 20 Jun 2010 12:00 On Jun 20, 2010, at 3:20 AM, Joe Perches <joe(a)perches.com> wrote: > Use the standard error logging mechanisms. > Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ > Remove __func__ from err calls, add '\n', rename to pr_err > > Signed-off-by: Joe Perches <joe(a)perches.com> > --- Eh. If we're going to make a change here, I'd rather it be to using dev_err instead, since most of the other spew in this driver uses similar. -- Jarod Wilson jarod(a)wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 20 Jun 2010 13:00 On Sun, 2010-06-20 at 11:58 -0400, Jarod Wilson wrote: > On Jun 20, 2010, at 3:20 AM, Joe Perches <joe(a)perches.com> wrote: > Use the standard error logging mechanisms. > > Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ > > Remove __func__ from err calls, add '\n', rename to pr_err > Eh. If we're going to make a change here, I'd rather it be to using > dev_err instead, since most of the other spew in this driver uses > similar. The idea is to eventually remove info/err/warn from usb.h by changing the code outside of drivers/usb first. There will always be some mix of printk or pr_<level> along with dev_<level> because struct device * is NULL or as is mostly used here there's no struct imon_context * available. I suggest you have a look and see which ones of these changes could use dev_<level> instead. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jarod Wilson on 20 Jun 2010 13:40
On Sun, Jun 20, 2010 at 12:53 PM, Joe Perches <joe(a)perches.com> wrote: > On Sun, 2010-06-20 at 11:58 -0400, Jarod Wilson wrote: >> On Jun 20, 2010, at 3:20 AM, Joe Perches <joe(a)perches.com> wrote: >> Use the standard error logging mechanisms. >> > Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ >> > Remove __func__ from err calls, add '\n', rename to pr_err >> Eh. If we're going to make a change here, I'd rather it be to using >> dev_err instead, since most of the other spew in this driver uses >> similar. > > The idea is to eventually remove info/err/warn from usb.h by > changing the code outside of drivers/usb first. > > There will always be some mix of printk or pr_<level> along > with dev_<level> because struct device * is NULL or as is > mostly used here there's no struct imon_context * available. > > I suggest you have a look and see which ones of these > changes could use dev_<level> instead. Ah, tbh, didn't look all that closely. Okay, I'll see if any of them can actually be made into dev_err instead of pr_err, but any that can't, sure, there's no problem w/this change. -- Jarod Wilson jarod(a)wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |