drivers/message/fusion: Adjust confusing if indentation
in [Kernel]
|
Prev: lockup_detector: Make DETECT_HUNT_TASK default depend on LOCKUP_DETECTOR
Next: [PATCH 2/2] serport: place serport serio device correctly in the device tree
From: Desai, Kashyap on 9 Aug 2010 10:30 > -----Original Message----- > From: Julia Lawall [mailto:julia(a)diku.dk] > Sent: Friday, August 06, 2010 1:57 AM > To: Moore, Eric; Support, Software; DL-MPT Fusion Linux; linux- > scsi(a)vger.kernel.org; linux-kernel(a)vger.kernel.org; kernel- > janitors(a)vger.kernel.org > Subject: [PATCH 34/42] drivers/message/fusion: Adjust confusing if > indentation > > From: Julia Lawall <julia(a)diku.dk> > > Indent the branch of an if. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r disable braces4@ > position p1,p2; > statement S1,S2; > @@ > > ( > if (...) { ... } > | > if (...) S1(a)p1 S2(a)p2 > ) > > @script:python@ > p1 << r.p1; > p2 << r.p2; > @@ > > if (p1[0].column == p2[0].column): > cocci.print_main("branch",p1) > cocci.print_secs("after",p2) > // </smpl> > > Signed-off-by: Julia Lawall <julia(a)diku.dk> > > --- > drivers/message/fusion/mptbase.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/message/fusion/mptbase.c > b/drivers/message/fusion/mptbase.c > index d8c668d..92e4b25 100644 > --- a/drivers/message/fusion/mptbase.c > +++ b/drivers/message/fusion/mptbase.c > @@ -8049,7 +8049,7 @@ union loginfo_type { > code_desc = ir_code_str[sas_loginfo.dw.code]; > if (sas_loginfo.dw.subcode >= > ARRAY_SIZE(raid_sub_code_str)) > - break; > + break; Agree. Please consider this patch as an ACKed. Thanks, Kashyap > if (sas_loginfo.dw.code == 0) > sub_code_desc = > raid_sub_code_str[sas_loginfo.dw.subcode]; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |