drivers:misc: sources for Init manager module
in [Kernel]
|
From: Greg KH on 24 Mar 2010 12:00 On Wed, Mar 24, 2010 at 08:24:01PM +0530, Pavan Savoy wrote: > 4. As Alan suggested, If I make it self-contained by pushing number of > line disciplines to a slightly larger number, then would it be OK ? That is fine with me, as long as you continue to work on fixing the issues in the code, and do not object to changing the user/kernel interface over time to be one that is more sane. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Marcel Holtmann on 24 Mar 2010 12:20 Hi Pavan, > I wanted to somehow put this in staging because then it would probably have a thorough architectural review process. > Some details about this driver - > > 1. This driver will be used by Bluetooth-BlueZ/FM-V4L2 and GPS (probably character device driver) using the EXPORTED symbols (-register/_unregister). > > 2. Much like the hciattach daemon which maintains N_HCI bluetooth line discipline, this driver will also have a User-Space N_TI_WL Init manager (UIM) maintaining the Line discipline. can you explain why you think this is needed and we can not interface this directly. If it is a serial port, what protocol does it talk? > 3. Because of the UIM should know when to install/uninstall line discipline, the /sys entry is created a root called UIM (a new kobject) and UIM daemon would write it's PID to it. I don't understand this. This sounds like a broken concept to me. > 4. As Alan suggested, If I make it self-contained by pushing number of line disciplines to a slightly larger number, then would it be OK ? Just from a quick look, I think within a few review cycles this might be able to get proper upstream inclusion. No idea why bother with staging in the first place. Lets do this correctly. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavan Savoy on 24 Mar 2010 12:30 --- On Wed, 24/3/10, Marcel Holtmann <marcel(a)holtmann.org> wrote: > From: Marcel Holtmann <marcel(a)holtmann.org> > Subject: Re: [PATCH 4/6] drivers:misc: sources for Init manager module > To: "Pavan Savoy" <pavan_savoy(a)yahoo.co.in> > Cc: "Greg KH" <gregkh(a)suse.de>, "PavanSavoy" <pavan_savoy(a)ti.com>, "alan(a)lxorguk.ukuu.org.uk" <alan(a)lxorguk.ukuu.org.uk>, "linux-kernel(a)vger.kernel.org" <linux-kernel(a)vger.kernel.org> > Date: Wednesday, 24 March, 2010, 9:41 PM > Hi Pavan, > > > > I wanted to somehow put this in staging because then > it would probably have a thorough architectural review > process. > > Some details about this driver - > > > > 1. This driver will be used by Bluetooth-BlueZ/FM-V4L2 > and GPS (probably character device driver) using the > EXPORTED symbols (-register/_unregister). > > > > 2. Much like the hciattach daemon which maintains > N_HCI bluetooth line discipline, this driver will also have > a User-Space� N_TI_WL Init manager (UIM) maintaining > the Line discipline. > > can you explain why you think this is needed and we can not > interface > this directly. If it is a serial port, what protocol does > it talk? Illustration: The BT driver on top of this ST driver, would create a hci0 interface, when someone does an DEVUP on that interface, the BT driver would then do a st-register - which in-turn would ask the hciattach-like daemon to install the line discipline for it via the sysfs entry. The same concept goes for FM-V4L2 and GPS character driver. The core of the problem is we cannot ask/install/ldisc_put for a line discipline from kernel space. > > > 3. Because of the UIM should know when to > install/uninstall line discipline, the /sys entry is created > a root called UIM (a new kobject) and UIM daemon would write > it's PID to it. > > I don't understand this. This sounds like a broken concept > to me. Yes, I don't feel good about it either. But how do I request for a line discipline from kernel space ? Currently a daemon has to run in user-space to maintain the ldisc, at all times, and I don't want to open TTY @ boot, and install Ldisc (tiocsetd) on it, without BT/FM or GPS core on chip being used - The Power Management team here would beat me up if I do that, and hence the very dumb idea of passing the PID of the daemon via sysfs entry, and the driver sending SIGUSR2 to that PID, daemon doing a tiocsetd upon that signal. > > > 4. As Alan suggested, If I make it self-contained by > pushing number of line disciplines to a slightly larger > number, then would it be OK ? > > Just from a quick look, I think within a few review cycles > this might be > able to get proper upstream inclusion. No idea why bother > with staging > in the first place. Lets do this correctly. > The only reason I wanted this to be in staging was to have sort of continuous review process, and in hope the driver wouldn't be forgotten. > Regards > > Marcel > > > The INTERNET now has a personality. YOURS! See your Yahoo! Homepage. http://in.yahoo.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 24 Mar 2010 12:30 On Wed, Mar 24, 2010 at 09:11:45AM -0700, Marcel Holtmann wrote: > > I wanted to somehow put this in staging because then it would probably have a thorough architectural review process. > > Some details about this driver - > > > > 1. This driver will be used by Bluetooth-BlueZ/FM-V4L2 and GPS (probably character device driver) using the EXPORTED symbols (-register/_unregister). > > > > 2. Much like the hciattach daemon which maintains N_HCI bluetooth line discipline, this driver will also have a User-Space N_TI_WL Init manager (UIM) maintaining the Line discipline. > > can you explain why you think this is needed and we can not interface > this directly. If it is a serial port, what protocol does it talk? > > > 3. Because of the UIM should know when to install/uninstall line discipline, the /sys entry is created a root called UIM (a new kobject) and UIM daemon would write it's PID to it. > > I don't understand this. This sounds like a broken concept to me. I also agree, those sysfs files are not acceptable, and will not work as-designed due to the pid namespace issues :( thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavan Savoy on 24 Mar 2010 12:40
--- On Wed, 24/3/10, Greg KH <gregkh(a)suse.de> wrote: > From: Greg KH <gregkh(a)suse.de> > Subject: Re: [PATCH 4/6] drivers:misc: sources for Init manager module > To: "Marcel Holtmann" <marcel(a)holtmann.org> > Cc: "Pavan Savoy" <pavan_savoy(a)yahoo.co.in>, "PavanSavoy" <pavan_savoy(a)ti.com>, "alan(a)lxorguk.ukuu.org.uk" <alan(a)lxorguk.ukuu.org.uk>, "linux-kernel(a)vger.kernel.org" <linux-kernel(a)vger.kernel.org> > Date: Wednesday, 24 March, 2010, 9:56 PM > On Wed, Mar 24, 2010 at 09:11:45AM > -0700, Marcel Holtmann wrote: > > > I wanted to somehow put this in staging because > then it would probably have a thorough architectural review > process. > > > Some details about this driver - > > > > > > 1. This driver will be used by > Bluetooth-BlueZ/FM-V4L2 and GPS (probably character device > driver) using the EXPORTED symbols (-register/_unregister). > > > > > > 2. Much like the hciattach daemon which maintains > N_HCI bluetooth line discipline, this driver will also have > a User-Space� N_TI_WL Init manager (UIM) maintaining > the Line discipline. > > > > can you explain why you think this is needed and we > can not interface > > this directly. If it is a serial port, what protocol > does it talk? > > > > > 3. Because of the UIM should know when to > install/uninstall line discipline, the /sys entry is created > a root called UIM (a new kobject) and UIM daemon would write > it's PID to it. > > > > I don't understand this. This sounds like a broken > concept to me. > > I also agree, those sysfs files are not acceptable, and > will not work > as-designed due to the pid namespace issues :( Ok, How do I then from kernel space, ask a user-space daemon to open the TTY port and do a tiocsetd on it ? [i.e ask for a line discipline to be installed ?] Can't open the TTY and TIOCSETD upon boot, because BT, FM and GPS might be used or not used anytime. And the idea of creating a device node, specifically for this and then doing an fasync/SIGIO was somehow rubbished. > > thanks, > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at� http://vger.kernel.org/majordomo-info.html > Please read the FAQ at� http://www.tux.org/lkml/ > The INTERNET now has a personality. YOURS! See your Yahoo! Homepage. http://in.yahoo.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |