Prev: [PATCH 1/2] lockup_detector: Convert per_cpu to __get_cpu_var for readability
Next: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slab_def.h>
From: Daniel Mack on 19 May 2010 07:10
Hi,

I stumbled over the r8a66597 UDC gadget driver as the the compiler
complained about the static inline function r8a66597_read():

drivers/usb/gadget/r8a66597-udc.c: In function 'irq_packet_read':
drivers/usb/gadget/r8a66597-udc.h:139: warning: 'data' may be used uninitialized in this function
drivers/usb/gadget/r8a66597-udc.h:139: note: 'data' was declared here

I know nothing about the code, but this function indeed looks bogus. Can
anyone have a look at this? Also, I wonder whether this function is
actually too big for a static inline.

Thanks,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/2] lockup_detector: Convert per_cpu to __get_cpu_var for readability
Next: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slab_def.h>