Prev: [PATCH 16/19] DMAENGINE: ste_dma40: fix suspend bug
Next: firewire: cdev ABI updates
From: Ryan Mallon on 20 Jun 2010 17:40
On 06/15/2010 12:44 PM, Ryan Mallon wrote:
> The ds2782_get_capacity function should return 0 on success, not the
> capacity value.
>
> Signed-off-by: Ryan Mallon <ryan(a)bluewatersys.com>
> ---
> drivers/power/ds2782_battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> index d762a0c..2afbeec 100644
> --- a/drivers/power/ds2782_battery.c
> +++ b/drivers/power/ds2782_battery.c
> @@ -163,7 +163,7 @@ static int ds2782_get_capacity(struct ds278x_info *info, int *capacity)
> if (err)
> return err;
> *capacity = raw;
> - return raw;
> + return 0;
> }
>
> static int ds2786_get_current(struct ds278x_info *info, int *current_uA)

Ping, Anton?

~Ryan

--
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan(a)bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Anton Vorontsov on 21 Jun 2010 11:20
On Mon, Jun 21, 2010 at 09:35:09AM +1200, Ryan Mallon wrote:
> On 06/15/2010 12:44 PM, Ryan Mallon wrote:
> > The ds2782_get_capacity function should return 0 on success, not the
> > capacity value.
> >
> > Signed-off-by: Ryan Mallon <ryan(a)bluewatersys.com>
> > ---
> > drivers/power/ds2782_battery.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> > index d762a0c..2afbeec 100644
> > --- a/drivers/power/ds2782_battery.c
> > +++ b/drivers/power/ds2782_battery.c
> > @@ -163,7 +163,7 @@ static int ds2782_get_capacity(struct ds278x_info *info, int *capacity)
> > if (err)
> > return err;
> > *capacity = raw;
> > - return raw;
> > + return 0;
> > }
> >
> > static int ds2786_get_current(struct ds278x_info *info, int *current_uA)
>
> Ping, Anton?

Applied to battery-2.6.35.git, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: CoffBeta on 22 Jun 2010 05:10
confirm

On Mon, Jun 21, 2010 at 05:35, Ryan Mallon <ryan(a)bluewatersys.com> wrote:
> On 06/15/2010 12:44 PM, Ryan Mallon wrote:
>> The ds2782_get_capacity function should return 0 on success, not the
>> capacity value.
>>
>> Signed-off-by: Ryan Mallon <ryan(a)bluewatersys.com>
>> ---
>> �drivers/power/ds2782_battery.c | � �2 +-
>> �1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
>> index d762a0c..2afbeec 100644
>> --- a/drivers/power/ds2782_battery.c
>> +++ b/drivers/power/ds2782_battery.c
>> @@ -163,7 +163,7 @@ static int ds2782_get_capacity(struct ds278x_info *info, int *capacity)
>> � � � if (err)
>> � � � � � � � return err;
>> � � � *capacity = raw;
>> - � � return raw;
>> + � � return 0;
>> �}
>>
>> �static int ds2786_get_current(struct ds278x_info *info, int *current_uA)
>
> Ping, Anton?
>
> ~Ryan
>
> --
> Bluewater Systems Ltd - ARM Technology Solution Centre
>
> Ryan Mallon � � � � � � � � � � 5 Amuri Park, 404 Barbadoes St
> ryan(a)bluewatersys.com � � � � � PO Box 13 889, Christchurch 8013
> http://www.bluewatersys.com � � New Zealand
> Phone: +64 3 3779127 � � � � � �Freecall: Australia 1800 148 751
> Fax: � +64 3 3779135 � � � � � � � � � � �USA 1800 261 2934
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at �http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at �http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 16/19] DMAENGINE: ste_dma40: fix suspend bug
Next: firewire: cdev ABI updates