Prev: [RFC]: new LSI MegaRAID driver implementation
Next: Subject: [PATCH] w1: mxc_w1: move probe and remove to the dev* text area.
From: tytso on 15 Feb 2010 14:30
On Thu, Feb 04, 2010 at 05:11:27PM +0100, Roel Kluin wrote:
> The error handling was missing.
>
> Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com>
> ---
> Is this needed?

Yep, it's added, thanks. I'm not entirely right the error handling is
completely correct in this function; in particular, if we fail after
this point in the function, and we've already changed the status of
EXT4_STATE_XATTR flag, but then we fail due to some error (maybe an
I/O error), it's not clear the cleanup section is properly unwinding
all of the side effects made so far in this function.

Still, adding the error check clearly makes the code better than it
was before, so I've added it to the ext4 patch queue.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [RFC]: new LSI MegaRAID driver implementation
Next: Subject: [PATCH] w1: mxc_w1: move probe and remove to the dev* text area.