fbdev: section cleanup in viafb driver
in [Kernel]
|
Prev: [PATCH 0/3] Automatically register i2c devices from the device tree
Next: [PATCH 2/3] i2c: Add OF-style registration and binding
From: Jonathan Corbet on 24 Jun 2010 16:20 On Thu, 17 Jun 2010 12:01:24 +0200 Henrik Kretzschmar <henne(a)nachtwindheim.de> wrote: > This patch moves two functions from .devexit to .text, > which are called on the probe error path. > Also a function which is called by probe is moved > from .text to .devinit. Sorry, it took me a while to take a look at this. The changes make sense, thanks. I have a few viafb bits and pieces, will collect them into my tree shortly. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: coffbeta on 25 Jun 2010 22:40
-static void __devexit via_teardown_subdevs(void) ------------------ coffbeta 2010-06-26 ------------------------------------------------------------- ·¢¼þÈË£ºHenrik Kretzschmar ·¢ËÍÈÕÆÚ£º2010-06-17 18:09:34 ÊÕ¼þÈË£ºJosephChan; ScottFang ³ËÍ£ºcorbet; FlorianSchandinat; linux-fbdev; linux-kernel; Henrik Kretzschmar Ö÷Ì⣺[PATCH] fbdev: section cleanup in viafb driver This patch moves two functions from .devexit to .text, which are called on the probe error path. Also a function which is called by probe is moved from .text to .devinit. WARNING: vmlinux.o(.devinit.text+0x2ca5): Section mismatch in reference from the function via_pci_probe() to the function .devexit.text:via_teardown_subdevs() The function __devinit via_pci_probe() references a function __devexit via_teardown_subdevs(). This is often seen when error handling in the init function uses functionality in the exit path. The fix is often to remove the __devexit annotation of via_teardown_subdevs() so it may be used outside an exit section. WARNING: vmlinux.o(.devinit.text+0x2cb1): Section mismatch in reference from the function via_pci_probe() to the function .devexit.text:via_pci_teardown_mmio() The function __devinit via_pci_probe() references a function __devexit via_pci_teardown_mmio(). This is often seen when error handling in the init function uses functionality in the exit path. The fix is often to remove the __devexit annotation of via_pci_teardown_mmio() so it may be used outside an exit section. Signed-off-by: Henrik Kretzschmar <henne(a)nachtwindheim.de> --- This patch is compile tested against Linus lastest git kernel. drivers/video/via/via-core.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c index e8cfe83..ec2e5aa 100644 --- a/drivers/video/via/via-core.c +++ b/drivers/video/via/via-core.c @@ -64,7 +64,7 @@ static inline int viafb_mmio_read(int reg) */ static u32 viafb_enabled_ints; -static void viafb_int_init(void) +static void __devinit viafb_int_init(void) { viafb_enabled_ints = 0; @@ -489,7 +489,7 @@ out_unmap: return ret; } -static void __devexit via_pci_teardown_mmio(struct viafb_dev *vdev) +static void via_pci_teardown_mmio(struct viafb_dev *vdev) { iounmap(vdev->fbmem); iounmap(vdev->engine_mmio); @@ -548,7 +548,7 @@ static int __devinit via_setup_subdevs(struct viafb_dev *vdev) return 0; } -static void __devexit via_teardown_subdevs(void) +static void via_teardown_subdevs(void) { int i; -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |