fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one
in [Kernel]
|
Prev: [PATCH][v8 5/7] x86/xen: The entrance for PV extension of HVM
Next: [PATCH] x86/kvm: Show guest system/user cputime in cpustat
From: Andy Shevchenko on 11 Mar 2010 02:20 On Thu, Mar 11, 2010 at 1:18 AM, OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp> wrote: >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_hi(ec >> 8); >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_lo(ec >> 8); >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_hi(ec); >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_lo(ec); > Why doesn't this use pack_hex_byte()? No specific reason, it could be so. Would you like me to change this? -- With Best Regards, Andy Shevchenko
From: Andy Shevchenko on 11 Mar 2010 03:10
On Thu, Mar 11, 2010 at 9:21 AM, Joe Perches <joe(a)perches.com> wrote: >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_hi(ec >> 8); >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_lo(ec >> 8); >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_hi(ec); >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_lo(ec); >> Why doesn't this use pack_hex_byte()? > or snprintf sprintf looks like overkill here. -- With Best Regards, Andy Shevchenko |