Prev: arch/powerpc/platforms/pseries: Use kasprintf
Next: [PATCH] powerpc/BSR: fix device_create() return value check
From: OGAWA Hirofumi on 11 Mar 2010 10:20
Andy Shevchenko <andy.shevchenko(a)gmail.com> writes:

> From: Andy Shevchenko <ext-andriy.shevchenko(a)nokia.com>
>
> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko(a)nokia.com>

Looks good to me.

Acked-by: OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp>

(From 1/4 with previous patch, I guess it's series of patches) Or I
should take this patch into my tree?

Thanks.

> ---
> fs/fat/dir.c | 14 +++++---------
> 1 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 530b4ca..5de1a70 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -19,6 +19,7 @@
> #include <linux/buffer_head.h>
> #include <linux/compat.h>
> #include <asm/uaccess.h>
> +#include <linux/kernel.h>
> #include "fat.h"
>
> /*
> @@ -149,19 +150,14 @@ static int uni16_to_x8(unsigned char *ascii, const wchar_t *uni, int len,
>
> while (*ip && ((len - NLS_MAX_CHARSET_SIZE) > 0)) {
> ec = *ip++;
> - if ( (charlen = nls->uni2char(ec, op, NLS_MAX_CHARSET_SIZE)) > 0) {
> + if ((charlen = nls->uni2char(ec, op, NLS_MAX_CHARSET_SIZE)) > 0) {
> op += charlen;
> len -= charlen;
> } else {
> if (uni_xlate == 1) {
> - *op = ':';
> - for (k = 4; k > 0; k--) {
> - nc = ec & 0xF;
> - op[k] = nc > 9 ? nc + ('a' - 10)
> - : nc + '0';
> - ec >>= 4;
> - }
> - op += 5;
> + *op++ = ':';
> + op = pack_hex_byte(op, ec >> 8);
> + op = pack_hex_byte(op, ec);
> len -= 5;
> } else {
> *op++ = '?';

--
OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Andy Shevchenko on 11 Mar 2010 10:20
On Thu, Mar 11, 2010 at 5:12 PM, OGAWA Hirofumi
<hirofumi(a)mail.parknet.co.jp> wrote:
> (From 1/4 with previous patch, I guess it's series of patches) Or I
> should take this patch into my tree?
It has only one in common - cleanup. Basically it's a bunch of
independent fixes.
Please, take it in your tree. thank you.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: OGAWA Hirofumi on 13 Mar 2010 06:10
Andy Shevchenko <andy.shevchenko(a)gmail.com> writes:

> const wchar_t *ip;
> wchar_t ec;
> - unsigned char *op, nc;
> + unsigned char *op;
> int charlen;
> - int k;

Ah, thanks. I fixed this myself before commit.
--
OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: arch/powerpc/platforms/pseries: Use kasprintf
Next: [PATCH] powerpc/BSR: fix device_create() return value check