fsfreeze: freeze_super and thaw_bdev don't play well together
in [Kernel]
|
Prev: fsfreeze: switch to using super methods everywhere
Next: power: Rename get_current to fix build failure / name conflict
From: Christoph Hellwig on 14 Jun 2010 11:30 This breaks the "feature" that we can freeze a block device that doesn't have a filesystem mounted yet. For filesystems using get_sb_bdev that prevents a new filesystem to be mounted on them. I'm not sure it's a particularly useful feature, but it's been there since day 1 of the freeze support. The easiest way to not break it would be to keep the per-sb freeze count only for that case and only check it during mount. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 15 Jun 2010 02:30
On Tue, Jun 15, 2010 at 10:01:07AM +1000, Dave Chinner wrote: > On Mon, Jun 14, 2010 at 11:22:19AM -0400, Christoph Hellwig wrote: > > This breaks the "feature" that we can freeze a block device that doesn't > > have a filesystem mounted yet. For filesystems using get_sb_bdev that > > prevents a new filesystem to be mounted on them. > > > > I'm not sure it's a particularly useful feature, but it's been there > > since day 1 of the freeze support. The easiest way to not break it > > would be to keep the per-sb freeze count only for that case and only > > check it during mount. > > You mean the per-bdev freeze count, right? So freeze/thaw_bdev would > have to remain? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |