genirq: Run irq handlers with interrupts disabled
in [Kernel]
|
Prev: [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c
Next: [GIT PULL] nilfs2 fixes for 2.6.34
From: Andi Kleen on 26 Mar 2010 02:20 > Drivers for whacky hardware still can reenable them in the handler > itself, if the need arises. (They do already due to lockdep) Can you please explain that lockdep reference? I don't think lockdep really forces on interrupts, does it? BTW the one problem I have with this patchkit is that it's clearly no stable candidate and I was hoping for a stable fix too. Any chance to at least approve my original patch for .32/.33 only? -Andi -- ak(a)linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 26 Mar 2010 09:10 On Fri, 26 Mar 2010, Andi Kleen wrote: > > Drivers for whacky hardware still can reenable them in the handler > > itself, if the need arises. (They do already due to lockdep) > > Can you please explain that lockdep reference? > I don't think lockdep really forces on interrupts, does it? Lockdep forces interrupts off. It yells at anyone enabling irqs in the handler. The ones which do that have been annotated with local_irq_enable_in_hardirq(), which is a nop for lockdep. > BTW the one problem I have with this patchkit is that it's clearly > no stable candidate and I was hoping for a stable fix too. > Any chance to at least approve my original patch for .32/.33 only? Why not simply force IRQF_DISABLED for all MSI interrupts. That still allows nesting for non MSI ones, but it limits the chance of throwing up reasonably well. That's a two liner. Can you please test whether it resolves the issue at hand ? Thanks, tglx --- diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index eb6078c..1d55e92 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -735,6 +735,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) if (new->flags & IRQF_ONESHOT) desc->status |= IRQ_ONESHOT; + if (desc->msi_desc) + new->flags |= IRQF_DISABLED; + if (!(desc->status & IRQ_NOAUTOEN)) { desc->depth = 0; desc->status &= ~IRQ_DISABLED; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andi Kleen on 30 Mar 2010 01:40 > Why not simply force IRQF_DISABLED for all MSI interrupts. That still > allows nesting for non MSI ones, but it limits the chance of throwing > up reasonably well. That's a two liner. > > Can you please test whether it resolves the issue at hand ? Sorry for the late answer. Got confirmation that this patch fixes the test case. Thanks. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 31 Mar 2010 07:20 On Tue, 30 Mar 2010, Andi Kleen wrote: > > Why not simply force IRQF_DISABLED for all MSI interrupts. That still > > allows nesting for non MSI ones, but it limits the chance of throwing > > up reasonably well. That's a two liner. > > > > Can you please test whether it resolves the issue at hand ? > > Sorry for the late answer. Got confirmation that this patch > fixes the test case. Thanks. Ok, I'll push it linus wards and cc stable. I think thats the least intrusive safe bet we can have right now. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 2 Apr 2010 08:40
On Wed 2010-03-31 13:16:37, Thomas Gleixner wrote: > On Tue, 30 Mar 2010, Andi Kleen wrote: > > > > Why not simply force IRQF_DISABLED for all MSI interrupts. That still > > > allows nesting for non MSI ones, but it limits the chance of throwing > > > up reasonably well. That's a two liner. > > > > > > Can you please test whether it resolves the issue at hand ? > > > > Sorry for the late answer. Got confirmation that this patch > > fixes the test case. Thanks. > > Ok, I'll push it linus wards and cc stable. I think thats the least > intrusive safe bet we can have right now. stable? I'd say thats way too intrusive for -stable... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |