From: Thomas Gleixner on
On Thu, 22 Apr 2010, Guillaume Knispel wrote:

> When the critical section in handle_edge_irq() is executed after
> IRQ_DISABLED has been set in the one in disable_irq(), the interrupt is

in the one ? -ENOPARSE

> acked and masked at controller level and IRQ_PENDING is set.
> ---
> arch/arm/Kconfig | 4 ----
> arch/arm/configs/acs5k_defconfig | 1 -
> arch/arm/configs/acs5k_tiny_defconfig | 1 -

Changing the defconfigs should be a separate patch and I'm not
going to push such a thing through the genirq tree. The stale
entries do not hurt.

> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 127b871..9bec343 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1423,7 +1423,7 @@ int setup_ioapic_entry(int apic_id, int irq,
> entry->polarity = polarity;
>
> /* Mask level triggered irqs.
> - * Use IRQ_DELAYED_DISABLE for edge triggered irqs.
> + * Edge triggered irqs can be resent by software.

That change is unrelated and should be done in a seperate patch.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Guillaume Knispel on
On Tue, 27 Apr 2010 15:42:11 +0200 (CEST)
Thomas Gleixner <tglx(a)linutronix.de> wrote:

> On Thu, 22 Apr 2010, Guillaume Knispel wrote:
[snip]
> > acked and masked at controller level and IRQ_PENDING is set.
> > ---
> > arch/arm/Kconfig | 4 ----
> > arch/arm/configs/acs5k_defconfig | 1 -
> > arch/arm/configs/acs5k_tiny_defconfig | 1 -
>
> Changing the defconfigs should be a separate patch and I'm not
> going to push such a thing through the genirq tree. The stale
> entries do not hurt.

Ok
In this separate patch, to I put "genirq" in the title?
Do I put it in the same series?

Cheers,
Guillaume Knispel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on
On Wed, 28 Apr 2010, Guillaume Knispel wrote:

> On Tue, 27 Apr 2010 15:42:11 +0200 (CEST)
> Thomas Gleixner <tglx(a)linutronix.de> wrote:
>
> > On Thu, 22 Apr 2010, Guillaume Knispel wrote:
> [snip]
> > > acked and masked at controller level and IRQ_PENDING is set.
> > > ---
> > > arch/arm/Kconfig | 4 ----
> > > arch/arm/configs/acs5k_defconfig | 1 -
> > > arch/arm/configs/acs5k_tiny_defconfig | 1 -
> >
> > Changing the defconfigs should be a separate patch and I'm not
> > going to push such a thing through the genirq tree. The stale
> > entries do not hurt.
>
> Ok
> In this separate patch, to I put "genirq" in the title?
> Do I put it in the same series?

Just keep them out for now and send them to the arch maintainers once
the change hits linus tree.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/