From: Tejun Heo on
On 07/20/2010 10:35 PM, Tejun Heo wrote:
> Workqueue can now handle high concurrency. Convert gfs to use
> workqueue instead of slow-work.
>
> * Steven pointed out that recovery path might be run from allocation
> path and thus requires forward progress guarantee without memory
> allocation. Create and use gfs_recovery_wq with rescuer. Please
> note that forward progress wasn't guaranteed with slow-work.
>
> * Updated to use non-reentrant workqueue.
>
> Signed-off-by: Tejun Heo <tj(a)kernel.org>
> Cc: Steven Whitehouse <swhiteho(a)redhat.com>

Steven, can you please review the change?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Steven Whitehouse on
Hi,

On Tue, 2010-07-20 at 22:35 +0200, Tejun Heo wrote:
> Workqueue can now handle high concurrency. Convert gfs to use
> workqueue instead of slow-work.
>
> * Steven pointed out that recovery path might be run from allocation
> path and thus requires forward progress guarantee without memory
> allocation. Create and use gfs_recovery_wq with rescuer. Please
> note that forward progress wasn't guaranteed with slow-work.
>
> * Updated to use non-reentrant workqueue.
>
> Signed-off-by: Tejun Heo <tj(a)kernel.org>
> Cc: Steven Whitehouse <swhiteho(a)redhat.com>
Acked-by: Steven Whitehouse <swhiteho(a)redhat.com>

I'm assuming that you'll push this along with the workqueue changes?
Probably easier than pushing it through my tree,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on
On 07/23/2010 12:20 PM, Steven Whitehouse wrote:
> Hi,
>
> On Tue, 2010-07-20 at 22:35 +0200, Tejun Heo wrote:
>> Workqueue can now handle high concurrency. Convert gfs to use
>> workqueue instead of slow-work.
>>
>> * Steven pointed out that recovery path might be run from allocation
>> path and thus requires forward progress guarantee without memory
>> allocation. Create and use gfs_recovery_wq with rescuer. Please
>> note that forward progress wasn't guaranteed with slow-work.
>>
>> * Updated to use non-reentrant workqueue.
>>
>> Signed-off-by: Tejun Heo <tj(a)kernel.org>
>> Cc: Steven Whitehouse <swhiteho(a)redhat.com>
> Acked-by: Steven Whitehouse <swhiteho(a)redhat.com>
>
> I'm assuming that you'll push this along with the workqueue changes?
> Probably easier than pushing it through my tree,

Yeah, I'll route this through the wq tree with all other workqueue
related changes.

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/