hid: Logitech G13 driver 0.0.3
in [Kernel]
|
Prev: [PATCH 4/7] Input: wacom - Convert remaining ids, part one
Next: mpt2sas: Fix &&/|| confusion in _scsih_sas_device_status_change_event()
From: Pavel Machek on 8 Jan 2010 11:40 Hi! > > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); > > What this attribute is for? Actually, all the new files this added need to be documented. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rick L. Vinyard, Jr. on 8 Jan 2010 12:00 Pavel Machek wrote: > Hi! > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); >> >> What this attribute is for? > > Actually, all the new files this added need to be documented. > Pavel > Which is better? A hid-g13.txt file added to Documentation/ or comments in the driver itself? Thanks, --- Rick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 8 Jan 2010 12:10 On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote: > Pavel Machek wrote: > > Hi! > > > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); > >> > >> What this attribute is for? > > > > Actually, all the new files this added need to be documented. > > Which is better? A hid-g13.txt file added to Documentation/ or comments in > the driver itself? Documentation. Coordinate with sysfs maintainer (gregkh). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 8 Jan 2010 12:20 On Fri, Jan 08, 2010 at 06:04:50PM +0100, Pavel Machek wrote: > On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote: > > Pavel Machek wrote: > > > Hi! > > > > > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); > > >> > > >> What this attribute is for? > > > > > > Actually, all the new files this added need to be documented. > > > > Which is better? A hid-g13.txt file added to Documentation/ or comments in > > the driver itself? > > Documentation. Coordinate with sysfs maintainer (gregkh). All sysfs files need to be documented in Documentation/ABI/ Please add the documentation there for your new sysfs files. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dmitry Torokhov on 8 Jan 2010 12:30
On Friday 08 January 2010 09:13:29 am Greg KH wrote: > On Fri, Jan 08, 2010 at 06:04:50PM +0100, Pavel Machek wrote: > > On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote: > > > Pavel Machek wrote: > > > > Hi! > > > > > > > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); > > > >> > > > >> What this attribute is for? > > > > > > > > Actually, all the new files this added need to be documented. > > > > > > Which is better? A hid-g13.txt file added to Documentation/ or comments > > > in the driver itself? > > > > Documentation. Coordinate with sysfs maintainer (gregkh). > > All sysfs files need to be documented in Documentation/ABI/ Please add > the documentation there for your new sysfs files. We need to have an agreement that all of them are needed first though. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |