Prev: drivers: Push down BKL into various drivers
Next: [PATCH] APIC: Remove unused variable
From: Arnd Bergmann on 5 Jun 2010 17:00
Commit 55929332c92 "drivers: Push down BKL into various drivers"
introduced a regression in hp_sdc_rtc, caused by a missing
change of the .unlocked_ioctl pointer to the newly introduced
function.

On Saturday 05 June 2010, Geert Uytterhoeven wrote:
> Something went wrong with this one:
>
> | drivers/input/misc/hp_sdc_rtc.c:681: warning: initialization from
> incompatible pointer type
> | drivers/input/misc/hp_sdc_rtc.c:665: warning:
> 'hp_sdc_rtc_unlocked_ioctl' defined but not used

Signed-off-by: Arnd Bergmann <arnd(a)arndb.de>

diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
index e00a1cc..c190664 100644
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -678,7 +678,7 @@ static const struct file_operations hp_sdc_rtc_fops = {
.llseek = no_llseek,
.read = hp_sdc_rtc_read,
.poll = hp_sdc_rtc_poll,
- .unlocked_ioctl = hp_sdc_rtc_ioctl,
+ .unlocked_ioctl = hp_sdc_rtc_unlocked_ioctl,
.open = hp_sdc_rtc_open,
.fasync = hp_sdc_rtc_fasync,
};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Frederic Weisbecker on 5 Jun 2010 17:10
On Sat, Jun 05, 2010 at 10:52:21PM +0200, Arnd Bergmann wrote:
> Commit 55929332c92 "drivers: Push down BKL into various drivers"
> introduced a regression in hp_sdc_rtc, caused by a missing
> change of the .unlocked_ioctl pointer to the newly introduced
> function.
>
> On Saturday 05 June 2010, Geert Uytterhoeven wrote:
> > Something went wrong with this one:
> >
> > | drivers/input/misc/hp_sdc_rtc.c:681: warning: initialization from
> > incompatible pointer type
> > | drivers/input/misc/hp_sdc_rtc.c:665: warning:
> > 'hp_sdc_rtc_unlocked_ioctl' defined but not used
>
> Signed-off-by: Arnd Bergmann <arnd(a)arndb.de>
>
> diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
> index e00a1cc..c190664 100644
> --- a/drivers/input/misc/hp_sdc_rtc.c
> +++ b/drivers/input/misc/hp_sdc_rtc.c
> @@ -678,7 +678,7 @@ static const struct file_operations hp_sdc_rtc_fops = {
> .llseek = no_llseek,
> .read = hp_sdc_rtc_read,
> .poll = hp_sdc_rtc_poll,
> - .unlocked_ioctl = hp_sdc_rtc_ioctl,
> + .unlocked_ioctl = hp_sdc_rtc_unlocked_ioctl,
> .open = hp_sdc_rtc_open,
> .fasync = hp_sdc_rtc_fasync,
> };



Queued for .35, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Geert Uytterhoeven on 6 Jun 2010 07:20
On Sat, Jun 5, 2010 at 22:52, Arnd Bergmann <arnd(a)arndb.de> wrote:
> Commit 55929332c92 "drivers: Push down BKL into various drivers"
> introduced a regression in hp_sdc_rtc, caused by a missing
> change of the .unlocked_ioctl pointer to the newly introduced
> function.
>
> On Saturday 05 June 2010, Geert Uytterhoeven wrote:
>> Something went wrong with this one:
>>
>> | drivers/input/misc/hp_sdc_rtc.c:681: warning: initialization from
>> incompatible pointer type
>> | drivers/input/misc/hp_sdc_rtc.c:665: warning:
>> 'hp_sdc_rtc_unlocked_ioctl' defined but not used
>
> Signed-off-by: Arnd Bergmann <arnd(a)arndb.de>

Acked-by: Geert Uytterhoeven <geert(a)linux-m68k.org>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: drivers: Push down BKL into various drivers
Next: [PATCH] APIC: Remove unused variable