Prev: Oops with strace_test
Next: [patch 11/15] vfs: truncate: append-only checking cleanup
From: Andi Kleen on 5 May 2008 09:50
Pekka Enberg wrote:
> Hi Andi,
>
> On Mon, May 5, 2008 at 4:29 PM, Andi Kleen <andi(a)firstfloor.org> wrote:
>> > Err, it checks the process stack when 4KSTACKS=n
>>
>> Ok then please add the two changes if you feel strongly about that
>> (to the latest version I sent).
>>
>> You always edit my patches anyways (usually driving me crazy when I have
>> dependent patches because nothing applies anymore when all the variables
>> got renamed like you often do) so I don't see any reason why you can't
>> do that here.
>
> Heh, do you mean to say that all this time I should have just asked
> Andrew to fix all the patches I've submitted rather take the trouble
> to do that myself after the review? ;-)

It is quite ok for trivial changes (like adding KERN_WARN or unlikely).
And yes Andrew does this all the time too. It makes sense because for
such trivialities it is less work to just change the patch than to comment.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: Oops with strace_test
Next: [patch 11/15] vfs: truncate: append-only checking cleanup