Prev: vt/console: try harder to print output when panicing
Next: fbcon: deinline large static function get_color()
From: Jesse Barnes on 23 Jun 2010 11:50
On Wed, 23 Jun 2010 13:19:55 +0200
Dan Carpenter <error27(a)gmail.com> wrote:

> intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
> opposed to drm_gem_object_unreference_unlocked()) so it needs to be
> called with "struct_mutex" held. If we don't hold the lock, it triggers
> a BUG_ON(!mutex_is_locked(&dev->struct_mutex));
>
> I also audited the other places that call intel_cleanup_ring_buffer()
> and they all hold the lock so they're OK.
>
> This was introduced in: 8187a2b70e3 "drm/i915: introduce
> intel_ring_buffer structure (V2)" and it's a regression from v2.6.34.
>
> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16247
>
> Signed-off-by: Dan Carpenter <error27(a)gmail.com>
> Reported-by: Benny Halevy <bhalevy(a)panasas.com>
> Tested-by: Benny Halevy <bhalevy(a)panasas.com>

Reminds me, Gordon can you add module unload testing to your set of
basic daily tests? To unload you need to unbind the fbcon interface
first, my script is like this:

echo 0 > /sys/class/vtconsole/vtcon1/bind
rmmod i915
rmmod drm_kms_helper
rmmod drm
modprobe i915
echo 1 > /sys/class/vtconsole/vtcon1/bind

If unload and re-load doesn't work please file a bug and see if you can
bisect it.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Eric Anholt on 1 Jul 2010 18:50
On Wed, 23 Jun 2010 13:19:55 +0200, Dan Carpenter <error27(a)gmail.com> wrote:
> intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
> opposed to drm_gem_object_unreference_unlocked()) so it needs to be
> called with "struct_mutex" held. If we don't hold the lock, it triggers
> a BUG_ON(!mutex_is_locked(&dev->struct_mutex));
>
> I also audited the other places that call intel_cleanup_ring_buffer()
> and they all hold the lock so they're OK.
>
> This was introduced in: 8187a2b70e3 "drm/i915: introduce
> intel_ring_buffer structure (V2)" and it's a regression from v2.6.34.
>
> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16247
>
> Signed-off-by: Dan Carpenter <error27(a)gmail.com>
> Reported-by: Benny Halevy <bhalevy(a)panasas.com>
> Tested-by: Benny Halevy <bhalevy(a)panasas.com>

Applied to for-linus. Thanks!
From: Chris Wilson on 25 Jul 2010 11:10
On Wed, 23 Jun 2010 08:47:18 -0700, Jesse Barnes <jbarnes(a)virtuousgeek.org> wrote:
> Reminds me, Gordon can you add module unload testing to your set of
> basic daily tests? To unload you need to unbind the fbcon interface
> first, my script is like this:
>
> echo 0 > /sys/class/vtconsole/vtcon1/bind
> rmmod i915
> rmmod drm_kms_helper
> rmmod drm
> modprobe i915
> echo 1 > /sys/class/vtconsole/vtcon1/bind

To which we could even add a kmemleak check.
After rmmod drm and before reloading i915:
echo scan > /sys/kernel/debug/kmemleak
cat /sys/kernel/debug/kmemleak > `hostname`-leaks.txt

If the output is not empty, file a bug. [Of course this means having to
compile kmemleak into the kernel. The DEBUG_KMEMLEAK option is found under
Kernel Hacking.] And since each generation has slightly different
initialization stanzas, we need to repeat the test on all platforms.
--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: vt/console: try harder to print output when panicing
Next: fbcon: deinline large static function get_color()