Prev: [PATCH resend] staging: fix dt3155 build
Next: arch/avr32: Fix build failure caused by typo
From: Mike Christie on 21 Apr 2010 17:40
On 04/21/2010 04:29 PM, Andrew Morton wrote:
> On Fri, 9 Apr 2010 14:21:28 +0000
> Konrad Rzeszutek Wilk<konrad(a)kernel.org> wrote:
>
>> For machines with IBFT 1.03 do scan the ACPI table for 'iBFT'
>> or for 'IBFT'. If the machine is in UEFI mode, only do the ACPI
>> table scan. For all other machines (pre IBFT 1.03) do
>> a memory scan if not found in the ACPI tables.
>>
>> Author: Konrad Rzeszutek Wilk<konrad(a)kernel.org>
>
> The Author: line is unneeded and inappropriate here. That's what the
> From: line does.
>
>> Acked-by: Peter Jones<pjones(a)redhat.com>
>> Tested-by: Mike Christie<michaelc(a)cs.wisc.edu>
>> Signed-off-by: Konrad Rzeszutek Wilk<konrad(a)kernel.org>
>
> Your covering email indicates that Mike and Peter wrote the patches,
> but neither of the patches have their signoffs. Can we please sort all
> this out?
>

I did a small fix to
ibft-update-ibft-handling-for-v103-of-the-spec.patch to get it to
compile. It looks like that patch has a "Reviewed-by: Mike Christie
<michaelc(a)cs.wisc.edu>". Feel free to change that to a Signed-off-by:
Mike Christie <michaelc(a)cs.wisc.edu> if needed.

I did not do any changes to
ibft-for-uefi-machines-actually-do-scan-acpi-for-ibft.patch.

I tested both patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 21 Apr 2010 17:40
On Fri, 9 Apr 2010 14:21:28 +0000
Konrad Rzeszutek Wilk <konrad(a)kernel.org> wrote:

> For machines with IBFT 1.03 do scan the ACPI table for 'iBFT'
> or for 'IBFT'. If the machine is in UEFI mode, only do the ACPI
> table scan. For all other machines (pre IBFT 1.03) do
> a memory scan if not found in the ACPI tables.
>
> Author: Konrad Rzeszutek Wilk <konrad(a)kernel.org>

The Author: line is unneeded and inappropriate here. That's what the
From: line does.

> Acked-by: Peter Jones <pjones(a)redhat.com>
> Tested-by: Mike Christie <michaelc(a)cs.wisc.edu>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad(a)kernel.org>

Your covering email indicates that Mike and Peter wrote the patches,
but neither of the patches have their signoffs. Can we please sort all
this out?


> ---
> drivers/firmware/iscsi_ibft_find.c | 31 +++++++++++++++++++------------
> 1 files changed, 19 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
> index 8f4d157..0bc3fae 100644
> --- a/drivers/firmware/iscsi_ibft_find.c
> +++ b/drivers/firmware/iscsi_ibft_find.c
> @@ -56,23 +56,12 @@ static int __init acpi_find_ibft(struct acpi_table_header *header)
> }
> #endif /* CONFIG_ACPI */
>
> -/*
> - * Routine used to find the iSCSI Boot Format Table. The logical
> - * kernel address is set in the ibft_addr global variable.
> - */
> -unsigned long __init find_ibft_region(unsigned long *sizep)
> +static int __init find_ibft_mem_scan(void)

The name seems weird. find_foo_scan(). So we're trying to find a scan
for a foo.

> {
> unsigned long pos;
> unsigned int len = 0;
> void *virt;
>
> - ibft_addr = NULL;
> -
> - /* iBFT 1.03 section 1.4.3.1 mandates that UEFI machines will
> - * only use ACPI for this */
> - if (efi_enabled)
> - return 0;
> -
> for (pos = IBFT_START; pos < IBFT_END; pos += 16) {
> /* The table can't be inside the VGA BIOS reserved space,
> * so skip that area */
>
> ...
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH resend] staging: fix dt3155 build
Next: arch/avr32: Fix build failure caused by typo