indiscriminate get_maintainer.pl usage
in [Kernel]
|
Prev: mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage
Next: [GIT PULL] [RESEND] sh updates for 2.6.34-rc7
From: Stefan Richter on 6 May 2010 02:50 > I should add --nogit option. The script does get some useful information out of git (but obviously also some questionable). --roles and --rolestats give away some more data... $ scripts/get_maintainer.pl --rolestats -f fs/eventpoll.c Alexander Viro <viro(a)zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS...) Andrew Morton <akpm(a)linux-foundation.org> (commit_signer:2/6=33%) "Eric W. Biederman" <ebiederm(a)xmission.com> (commit_signer:2/6=33%) Davide Libenzi <davidel(a)xmailserver.org> (commit_signer:2/6=33%) Roland Dreier <rolandd(a)cisco.com> (commit_signer:1/6=17%) Stefan Richter <stefanr(a)s5r6.in-berlin.de> (commit_signer:1/6=17%) linux-fsdevel(a)vger.kernel.org (open list:FILESYSTEMS (VFS...) linux-kernel(a)vger.kernel.org (open list) ....but still don't distinguish between signed-off-by or reviewed-by on one hand, and reported-by and tested-by on the other hand. Cc'ing a reporter or tester would only make sense if the patch changes something that directly affects the reporter's/ tester's setup, e.g. reworks a provisional fix. -- Stefan Richter -=====-==-=- -=-= --==- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Davide Libenzi on 6 May 2010 11:50 On Thu, 6 May 2010, Stefan Richter wrote: > > I should add --nogit option. > > The script does get some useful information out of git (but obviously > also some questionable). > > --roles and --rolestats give away some more data... > > $ scripts/get_maintainer.pl --rolestats -f fs/eventpoll.c > Alexander Viro <viro(a)zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS...) > Andrew Morton <akpm(a)linux-foundation.org> (commit_signer:2/6=33%) > "Eric W. Biederman" <ebiederm(a)xmission.com> (commit_signer:2/6=33%) > Davide Libenzi <davidel(a)xmailserver.org> (commit_signer:2/6=33%) > Roland Dreier <rolandd(a)cisco.com> (commit_signer:1/6=17%) > Stefan Richter <stefanr(a)s5r6.in-berlin.de> (commit_signer:1/6=17%) > linux-fsdevel(a)vger.kernel.org (open list:FILESYSTEMS (VFS...) > linux-kernel(a)vger.kernel.org (open list) > > ...but still don't distinguish between signed-off-by or reviewed-by on > one hand, and reported-by and tested-by on the other hand. Cc'ing a > reporter or tester would only make sense if the patch changes something > that directly affects the reporter's/ tester's setup, e.g. reworks a > provisional fix. I have always maintained that code w/out the need of explicit entry in the MAINTAINERS file. For isolated files people usually include the copyright owners and the ones listed in the comment header in general. No problem in being explicitly listed if this causes noise during bug reporting. - Davide -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 6 May 2010 13:00 On Thu, 2010-05-06 at 08:42 -0700, Davide Libenzi wrote: > On Thu, 6 May 2010, Stefan Richter wrote: > > > I should add --nogit option. > > The script does get some useful information out of git (but obviously > > also some questionable). Stefan, I think that's the price you pay for fame. Try to do good, get more unsolicited email. > > --roles and --rolestats give away some more data... > > $ scripts/get_maintainer.pl --rolestats -f fs/eventpoll.c > > Alexander Viro <viro(a)zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS...) > > Andrew Morton <akpm(a)linux-foundation.org> (commit_signer:2/6=33%) > > "Eric W. Biederman" <ebiederm(a)xmission.com> (commit_signer:2/6=33%) > > Davide Libenzi <davidel(a)xmailserver.org> (commit_signer:2/6=33%) > > Roland Dreier <rolandd(a)cisco.com> (commit_signer:1/6=17%) > > Stefan Richter <stefanr(a)s5r6.in-berlin.de> (commit_signer:1/6=17%) > > linux-fsdevel(a)vger.kernel.org (open list:FILESYSTEMS (VFS...) > > linux-kernel(a)vger.kernel.org (open list) > > > > ...but still don't distinguish between signed-off-by or reviewed-by on > > one hand, and reported-by and tested-by on the other hand. Cc'ing a > > reporter or tester would only make sense if the patch changes something > > that directly affects the reporter's/ tester's setup, e.g. reworks a > > provisional fix. > > I have always maintained that code w/out the need of explicit entry in the > MAINTAINERS file. For isolated files people usually include the copyright > owners and the ones listed in the comment header in general. > No problem in being explicitly listed if this causes noise during bug > reporting. There is also the --git-blame option for patches, but blame is also only a semi-useful tool, as it could show cleanup patches on individual as authors. Another option to get_maintainers is --file-emails which looks inside a file for email addresses. Right now, the default for # of git commits signed to be added to the CC list is 1. It's possible to change the default. --git-min-signatures => number of signatures required (default: 1) --git-max-maintainers => maximum maintainers to add (default: 5) --git-min-percent => minimum percentage of commits required (default: 5) Maybe some fine-tuning of the defaults could be useful. Suggestions? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Davide Libenzi on 6 May 2010 14:10 On Thu, 6 May 2010, Joe Perches wrote: > There is also the --git-blame option for patches, but blame > is also only a semi-useful tool, as it could show cleanup patches > on individual as authors. > > Another option to get_maintainers is --file-emails which looks > inside a file for email addresses. > > Right now, the default for # of git commits signed to be > added to the CC list is 1. It's possible to change the default. > > --git-min-signatures => number of signatures required (default: 1) > --git-max-maintainers => maximum maintainers to add (default: 5) > --git-min-percent => minimum percentage of commits required (default: 5) > > Maybe some fine-tuning of the defaults could be useful. > > Suggestions? (not knowing the get_maintainers internals ...) Maybe if you weigh each contributor by the amount (in terms of diffstat modulo) of changes, you can get more accurate results. Part of the weight might be related to the time distance (relative to current time) since the changeset. - Davide -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Roland Dreier on 6 May 2010 16:20
> $ scripts/get_maintainer.pl --rolestats -f fs/eventpoll.c > Alexander Viro <viro(a)zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS...) > Andrew Morton <akpm(a)linux-foundation.org> (commit_signer:2/6=33%) > "Eric W. Biederman" <ebiederm(a)xmission.com> (commit_signer:2/6=33%) > Davide Libenzi <davidel(a)xmailserver.org> (commit_signer:2/6=33%) > Roland Dreier <rolandd(a)cisco.com> (commit_signer:1/6=17%) > Stefan Richter <stefanr(a)s5r6.in-berlin.de> (commit_signer:1/6=17%) > linux-fsdevel(a)vger.kernel.org (open list:FILESYSTEMS (VFS...) > linux-kernel(a)vger.kernel.org (open list) And my appearing here is a bit silly as well, since I have made one commit to fs/eventpoll.c that changed one line. A bit different in scope from Davide who designed and wrote the whole thing... OTOH it's not clear how smart we want get_maintainer.pl to try to be. - R. -- Roland Dreier <rolandd(a)cisco.com> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |