Prev: [PATCH 1/4] dmaengine: correct onstack wait_queue_head declaration
Next: [GIT PULL] i2c fix for 2.6.33
From: Eric Paris on 5 Feb 2010 11:40
On Fri, Feb 5, 2010 at 8:51 AM, Joris Dolderer
<vorstadtkind(a)googlemail.com> wrote:
> Hi,
>
> This is my first software submit, so please don't spare with detailed
> constructive critics and be nice to me ;-).

I would suggest that you take a careful look at
Documentation/CodingStyle and Documentation/SubmittingPatches. There
appear to be quite a number of issues which you may believe to be
purely cosmetic or aesthetic but coding style and proper submission of
patches are very important to keeping the kernel easy to maintain and
develop further.

I will try to take a look a the contents of the patch over the weekend
and will give you some feedback.

Thanks!
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/4] dmaengine: correct onstack wait_queue_head declaration
Next: [GIT PULL] i2c fix for 2.6.33