From: Takuya Yoshikawa on
Hi, I found a typo.

Gui Jianfeng wrote:
> +- blkio.weight_device
> + - One can specify per cgroup per device rules using this interface.
> + These rules override the default value of group weight as specified
> + by blkio.weight.
> +
> + Following is the format.
> +
> + #echo dev_maj:dev_minor weight > /patch/to/cgroup/blkio.weight_device

You mean "path to"?

Thanks,
Takuya

> +
> + weight=0 means removing weight on a given device.
> +
> + Examples:
> + Configure weight=300 on /dev/sdb (8:16) in this cgroup
> + # echo 8:16 300 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:16 300
> +
> + Configure weight=500 on /dev/sda (8:0) in this cgroup
> + # echo 8:0 500 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:0 500
> + 8:16 300
> +
> + Remove specific weight for /dev/sda in this cgroup
> + # echo 8:0 0 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:16 300
> +
> CFQ sysfs tunable
> =================
> /sys/block/<disk>/queue/iosched/group_isolation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Gui Jianfeng on
Takuya Yoshikawa wrote:
> Hi, I found a typo.
>
> Gui Jianfeng wrote:
>> +- blkio.weight_device
>> + - One can specify per cgroup per device rules using this interface.
>> + These rules override the default value of group weight as
>> specified
>> + by blkio.weight.
>> +
>> + Following is the format.
>> +
>> + #echo dev_maj:dev_minor weight >
>> /patch/to/cgroup/blkio.weight_device
>
> You mean "path to"?
>

yeah, will fix.

Thanks
Gui

> Thanks,
> Takuya
>
>> +
>> + weight=0 means removing weight on a given device.
>> +
>> + Examples:
>> + Configure weight=300 on /dev/sdb (8:16) in this cgroup
>> + # echo 8:16 300 > blkio.weight_device
>> + # cat blkio.weight_device
>> + dev weight
>> + 8:16 300
>> +
>> + Configure weight=500 on /dev/sda (8:0) in this cgroup
>> + # echo 8:0 500 > blkio.weight_device
>> + # cat blkio.weight_device
>> + dev weight
>> + 8:0 500
>> + 8:16 300
>> +
>> + Remove specific weight for /dev/sda in this cgroup
>> + # echo 8:0 0 > blkio.weight_device
>> + # cat blkio.weight_device
>> + dev weight
>> + 8:16 300
>> +
>> CFQ sysfs tunable
>> =================
>> /sys/block/<disk>/queue/iosched/group_isolation
>
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Takuya Yoshikawa on
Hi, thank you for fixing ...

Gui Jianfeng wrote:
> +- blkio.weight_device
> + - One can specify per cgroup per device rules using this interface.
> + These rules override the default value of group weight as specified
> + by blkio.weight.
> +
> + Following is the format.
> +
> + #echo dev_maj:dev_minor weight > /pach/to/cgroup/blkio.weight_device

You deleted wrong character! We need 't' not 'c'.

Thanks,
Takuya

> +
> + weight=0 means removing weight on a given device.
> +
> + Examples:
> + Configure weight=300 on /dev/sdb (8:16) in this cgroup
> + # echo 8:16 300 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:16 300
> +
> + Configure weight=500 on /dev/sda (8:0) in this cgroup
> + # echo 8:0 500 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:0 500
> + 8:16 300
> +
> + Remove specific weight for /dev/sda in this cgroup
> + # echo 8:0 0 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:16 300
> +
> CFQ sysfs tunable
> =================
> /sys/block/<disk>/queue/iosched/group_isolation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Gui Jianfeng on
Takuya Yoshikawa wrote:
> Hi, thank you for fixing ...
>
> Gui Jianfeng wrote:
>> +- blkio.weight_device
>> + - One can specify per cgroup per device rules using this interface.
>> + These rules override the default value of group weight as
>> specified
>> + by blkio.weight.
>> +
>> + Following is the format.
>> +
>> + #echo dev_maj:dev_minor weight >
>> /pach/to/cgroup/blkio.weight_device
>
> You deleted wrong character! We need 't' not 'c'.

OOPS, Sorry :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Vivek Goyal on
On Fri, Mar 05, 2010 at 10:26:39AM +0800, Gui Jianfeng wrote:
> Here is the document for blkio.weight_device
>
> Signed-off-by: Gui Jianfeng <guijianfeng(a)cn.fujitsu.com>

Looks good to me.

Acked-by: Vivek Goyal <vgoyal(a)redhat.com>

Vivek

> ---
> Documentation/cgroups/blkio-controller.txt | 35 +++++++++++++++++++++++++++-
> 1 files changed, 34 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/cgroups/blkio-controller.txt b/Documentation/cgroups/blkio-controller.txt
> index 630879c..e551c85 100644
> --- a/Documentation/cgroups/blkio-controller.txt
> +++ b/Documentation/cgroups/blkio-controller.txt
> @@ -76,7 +76,9 @@ CONFIG_DEBUG_BLK_CGROUP
> Details of cgroup files
> =======================
> - blkio.weight
> - - Specifies per cgroup weight.
> + - Specifies per cgroup weight. This is default weight of the group
> + on all the devices until and unless overridden by per device rule.
> + (See blkio.weight_device).
>
> Currently allowed range of weights is from 100 to 1000.
>
> @@ -99,6 +101,37 @@ Details of cgroup files
> and minor number of the device and third field specifies the number
> of times a group was dequeued from a particular device.
>
> +- blkio.weight_device
> + - One can specify per cgroup per device rules using this interface.
> + These rules override the default value of group weight as specified
> + by blkio.weight.
> +
> + Following is the format.
> +
> + #echo dev_maj:dev_minor weight > /pach/to/cgroup/blkio.weight_device
> +
> + weight=0 means removing weight on a given device.
> +
> + Examples:
> + Configure weight=300 on /dev/sdb (8:16) in this cgroup
> + # echo 8:16 300 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:16 300
> +
> + Configure weight=500 on /dev/sda (8:0) in this cgroup
> + # echo 8:0 500 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:0 500
> + 8:16 300
> +
> + Remove specific weight for /dev/sda in this cgroup
> + # echo 8:0 0 > blkio.weight_device
> + # cat blkio.weight_device
> + dev weight
> + 8:16 300
> +
> CFQ sysfs tunable
> =================
> /sys/block/<disk>/queue/iosched/group_isolation
> --
> 1.5.4.rc3
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/