ipmi: Fix ACPI detecting with regspacing
in [Kernel]
|
Prev: [PATCH net-next 2/4] drivers/net/wireless: Use wiphy_<level>
Next: [PATCH] x86, acpi: handle xapic/x2apic at same time
From: Bjorn Helgaas on 27 Jul 2010 13:50 On Tuesday, July 27, 2010 11:28:28 am Yinghai Lu wrote: > On 07/27/2010 10:23 AM, Bjorn Helgaas wrote: > > On Tuesday, July 27, 2010 11:07:55 am Yinghai Lu wrote: > >> On 07/27/2010 08:34 AM, Bjorn Helgaas wrote: > >>> On Monday, July 26, 2010 03:48:02 pm Yinghai Lu wrote: > >>>> > >>>> after the commint that change ipmi_si detecting sequence from SMBIOS/ACPI to ACPI/SMBIOS, > >>>> > >>>> | commit 754d453185275951d39792865927ec494fa1ebd8 > >>>> | Author: Matthew Garrett <mjg(a)redhat.com> > >>>> | Date: Wed May 26 14:43:47 2010 -0700 > >>>> | > >>>> | ipmi: change device discovery order > >>>> | > >>>> | The ipmi spec provides an ordering for si discovery. Change the driver to > >>>> | match, with the exception of preferring smbios to SPMI as HPs (at least) > >>>> | contain accurate information in the former but not the latter. > >>>> > >>>> ipmi_si can not be initialized. > >>> > >>> I think this patch makes sense, as long as this is not a bringup > >>> issue that only affects pre-release firmware. If this only affects > >>> a prototype, it would be better to change the firmware so it conforms > >>> to the conventional _CRS usage of systems in the field. > >>> > >>> To that end, I'd like to know what system this is, and whether IPMI > >>> works under Windows on this system. We know that Windows doesn't > >>> look at SMBIOS or SPMI, so if Windows works, it must be doing something > >>> similar to your patch. > >> > >> Sun Fire X4800. > >> > >> Yes. other OSes work and pass certification. > > > > Please put this information in the changelog (if that wasn't obvious). > > I don't want to mention other os. Sigh. Why is this so difficult? It's very useful to know which other OSes work and *how* they work. If another OS (particularly a popular one like Windows) works, and we know it's using the ACPI namespace, that tells us we need a change like yours. If another OS works but is using SPMI, that tells us nothing about whether we should make this change. If no other OS uses the namespace, then we might be adding a Linux change just to deal with a firmware defect on this machine, and that sort of change could easily break other machines. I don't think that's the case here; I think we *should* make the change you're proposing. But it's just a good practice to be diligent about documenting the reasons for the changes we make. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 28 Jul 2010 15:30 On Tue, 27 Jul 2010 11:41:10 -0600 Bjorn Helgaas <bjorn.helgaas(a)hp.com> wrote: > On Tuesday, July 27, 2010 11:28:28 am Yinghai Lu wrote: > > On 07/27/2010 10:23 AM, Bjorn Helgaas wrote: > > > On Tuesday, July 27, 2010 11:07:55 am Yinghai Lu wrote: > > >> On 07/27/2010 08:34 AM, Bjorn Helgaas wrote: > > >>> On Monday, July 26, 2010 03:48:02 pm Yinghai Lu wrote: > > >>>> > > >>>> after the commint that change ipmi_si detecting sequence from SMBIOS/ACPI to ACPI/SMBIOS, > > >>>> > > >>>> | commit 754d453185275951d39792865927ec494fa1ebd8 > > >>>> | Author: Matthew Garrett <mjg(a)redhat.com> > > >>>> | Date: Wed May 26 14:43:47 2010 -0700 > > >>>> | > > >>>> | ipmi: change device discovery order > > >>>> | > > >>>> | The ipmi spec provides an ordering for si discovery. Change the driver to > > >>>> | match, with the exception of preferring smbios to SPMI as HPs (at least) > > >>>> | contain accurate information in the former but not the latter. > > >>>> > > >>>> ipmi_si can not be initialized. > > >>> > > >>> I think this patch makes sense, as long as this is not a bringup > > >>> issue that only affects pre-release firmware. If this only affects > > >>> a prototype, it would be better to change the firmware so it conforms > > >>> to the conventional _CRS usage of systems in the field. > > >>> > > >>> To that end, I'd like to know what system this is, and whether IPMI > > >>> works under Windows on this system. We know that Windows doesn't > > >>> look at SMBIOS or SPMI, so if Windows works, it must be doing something > > >>> similar to your patch. > > >> > > >> Sun Fire X4800. > > >> > > >> Yes. other OSes work and pass certification. > > > > > > Please put this information in the changelog (if that wasn't obvious). > > > > I don't want to mention other os. > > Sigh. Why is this so difficult? It wasn't for me ;) Do we have acks for 2.6.36 and a -stable backport on this patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on 28 Jul 2010 15:40
On 07/28/2010 12:22 PM, Andrew Morton wrote: > On Tue, 27 Jul 2010 11:41:10 -0600 > Bjorn Helgaas <bjorn.helgaas(a)hp.com> wrote: > >> On Tuesday, July 27, 2010 11:28:28 am Yinghai Lu wrote: >>> On 07/27/2010 10:23 AM, Bjorn Helgaas wrote: >>>> On Tuesday, July 27, 2010 11:07:55 am Yinghai Lu wrote: >>>>> On 07/27/2010 08:34 AM, Bjorn Helgaas wrote: >>>>>> On Monday, July 26, 2010 03:48:02 pm Yinghai Lu wrote: >>>>>>> >>>>>>> after the commint that change ipmi_si detecting sequence from SMBIOS/ACPI to ACPI/SMBIOS, >>>>>>> >>>>>>> | commit 754d453185275951d39792865927ec494fa1ebd8 >>>>>>> | Author: Matthew Garrett <mjg(a)redhat.com> >>>>>>> | Date: Wed May 26 14:43:47 2010 -0700 >>>>>>> | >>>>>>> | ipmi: change device discovery order >>>>>>> | >>>>>>> | The ipmi spec provides an ordering for si discovery. Change the driver to >>>>>>> | match, with the exception of preferring smbios to SPMI as HPs (at least) >>>>>>> | contain accurate information in the former but not the latter. >>>>>>> >>>>>>> ipmi_si can not be initialized. >>>>>> >>>>>> I think this patch makes sense, as long as this is not a bringup >>>>>> issue that only affects pre-release firmware. If this only affects >>>>>> a prototype, it would be better to change the firmware so it conforms >>>>>> to the conventional _CRS usage of systems in the field. >>>>>> >>>>>> To that end, I'd like to know what system this is, and whether IPMI >>>>>> works under Windows on this system. We know that Windows doesn't >>>>>> look at SMBIOS or SPMI, so if Windows works, it must be doing something >>>>>> similar to your patch. >>>>> >>>>> Sun Fire X4800. >>>>> >>>>> Yes. other OSes work and pass certification. >>>> >>>> Please put this information in the changelog (if that wasn't obvious). >>> >>> I don't want to mention other os. >> >> Sigh. Why is this so difficult? > > It wasn't for me ;) > > Do we have acks for 2.6.36 and a -stable backport on this patch? Matthew Garrett <mjg(a)redhat.com> gave ack to it. looks like Matthew's patch only get into 2.6.35. So we need it for 2.6.35 and later. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |