ipmi: fix module param sparse warnings
in [Kernel]
|
Prev: cifs: define inode-level cache object and register them
Next: [PATCH 1/5] cpumask: truncate mm_struct.cpu_vm_mask for CONFIG_CPUMASK_OFFSTACK
From: Rusty Russell on 25 Jun 2010 09:00 On Fri, 25 Jun 2010 07:51:22 am Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > The <arg> parameter in module_param_cb() should be a pointer, Well, I don't think there's anything wrong with it being a function. The actual problem is that it tries to figure out if the arg is a bool or an int: if someone wants to work through the 700-odd cases of module_param*bool and convert those vars to actual bools, that'd allow us to get rid of that logic. Meanwhile, we can do this instead. Does it solve it as well? Subject: ipmi: fix module param sparse warnings Date: Thu, 24 Jun 2010 15:21:22 -0700 From: Randy Dunlap <randy.dunlap(a)oracle.com> The <arg> parameter in module_param_cb() should be a pointer, i.e., like one of these: union { void *arg; const struct kparam_string *str; const struct kparam_array *arr; }; sparse complains: drivers/char/ipmi/ipmi_watchdog.c:303:1: error: cannot dereference this type drivers/char/ipmi/ipmi_watchdog.c:307:1: error: cannot dereference this type drivers/char/ipmi/ipmi_watchdog.c:311:1: error: cannot dereference this type Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> Cc: Corey Minyard <minyard(a)acm.org> Signed-off-by: Rusty Russell <rusty(a)rustcorp.com.au> --- drivers/char/ipmi/ipmi_watchdog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-next-20100528.orig/drivers/char/ipmi/ipmi_watchdog.c +++ linux-next-20100528/drivers/char/ipmi/ipmi_watchdog.c @@ -300,15 +300,15 @@ MODULE_PARM_DESC(timeout, "Timeout value module_param(pretimeout, timeout, 0644); MODULE_PARM_DESC(pretimeout, "Pretimeout value in seconds."); -module_param_cb(action, ¶m_ops_str, action_op, 0644); +module_param_cb(action, ¶m_ops_str, &action_op, 0644); MODULE_PARM_DESC(action, "Timeout action. One of: " "reset, none, power_cycle, power_off."); -module_param_cb(preaction, ¶m_ops_str, preaction_op, 0644); +module_param_cb(preaction, ¶m_ops_str, &preaction_op, 0644); MODULE_PARM_DESC(preaction, "Pretimeout action. One of: " "pre_none, pre_smi, pre_nmi, pre_int."); -module_param_cb(preop, ¶m_ops_str, preop_op, 0644); +module_param_cb(preop, ¶m_ops_str, &preop_op, 0644); MODULE_PARM_DESC(preop, "Pretimeout driver operation. One of: " "preop_none, preop_panic, preop_give_data."); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 25 Jun 2010 12:30 On 06/25/10 05:50, Rusty Russell wrote: > On Fri, 25 Jun 2010 07:51:22 am Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap(a)oracle.com> >> >> The <arg> parameter in module_param_cb() should be a pointer, > > Well, I don't think there's anything wrong with it being a function. Ah, yes, I see. That makes it a sparse error, right? > The actual problem is that it tries to figure out if the arg is a bool > or an int: if someone wants to work through the 700-odd cases of > module_param*bool and convert those vars to actual bools, that'd allow > us to get rid of that logic. > > Meanwhile, we can do this instead. Does it solve it as well? Yes, that also fixes it. Thanks. > Subject: ipmi: fix module param sparse warnings > Date: Thu, 24 Jun 2010 15:21:22 -0700 > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > The <arg> parameter in module_param_cb() should be a pointer, > i.e., like one of these: > union { > void *arg; > const struct kparam_string *str; > const struct kparam_array *arr; > }; > > sparse complains: > drivers/char/ipmi/ipmi_watchdog.c:303:1: error: cannot dereference this type > drivers/char/ipmi/ipmi_watchdog.c:307:1: error: cannot dereference this type > drivers/char/ipmi/ipmi_watchdog.c:311:1: error: cannot dereference this type > > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> > Cc: Corey Minyard <minyard(a)acm.org> > Signed-off-by: Rusty Russell <rusty(a)rustcorp.com.au> > --- > drivers/char/ipmi/ipmi_watchdog.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > --- linux-next-20100528.orig/drivers/char/ipmi/ipmi_watchdog.c > +++ linux-next-20100528/drivers/char/ipmi/ipmi_watchdog.c > @@ -300,15 +300,15 @@ MODULE_PARM_DESC(timeout, "Timeout value > module_param(pretimeout, timeout, 0644); > MODULE_PARM_DESC(pretimeout, "Pretimeout value in seconds."); > > -module_param_cb(action, ¶m_ops_str, action_op, 0644); > +module_param_cb(action, ¶m_ops_str, &action_op, 0644); > MODULE_PARM_DESC(action, "Timeout action. One of: " > "reset, none, power_cycle, power_off."); > > -module_param_cb(preaction, ¶m_ops_str, preaction_op, 0644); > +module_param_cb(preaction, ¶m_ops_str, &preaction_op, 0644); > MODULE_PARM_DESC(preaction, "Pretimeout action. One of: " > "pre_none, pre_smi, pre_nmi, pre_int."); > > -module_param_cb(preop, ¶m_ops_str, preop_op, 0644); > +module_param_cb(preop, ¶m_ops_str, &preop_op, 0644); > MODULE_PARM_DESC(preop, "Pretimeout driver operation. One of: " > "preop_none, preop_panic, preop_give_data."); > > > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rusty Russell on 28 Jun 2010 05:40
On Sat, 26 Jun 2010 01:51:13 am Randy Dunlap wrote: > On 06/25/10 05:50, Rusty Russell wrote: > > On Fri, 25 Jun 2010 07:51:22 am Randy Dunlap wrote: > >> From: Randy Dunlap <randy.dunlap(a)oracle.com> > >> > >> The <arg> parameter in module_param_cb() should be a pointer, > > > > Well, I don't think there's anything wrong with it being a function. > > Ah, yes, I see. That makes it a sparse error, right? Well, it's a weird corner case, but yes. > > Meanwhile, we can do this instead. Does it solve it as well? > > Yes, that also fixes it. > Thanks. Thanks, I've added your tested-by. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |