From: Konrad Rzeszutek Wilk on
> @@ -169,6 +170,7 @@ struct irq_2_iommu;
> * @pending_mask: pending rebalanced interrupts
> * @threads_active: number of irqaction threads currently running
> * @wait_for_threads: wait queue for sync_irq to wait for threaded handlers
> + * @poll_timer: timer for IRQ polling

I looked over the patches and they all look good to my eyes.

The only thing that looked out of place was the above comment.
Would it make sense to move the comment one tab to the left?

> * @dir: /proc/irq/ procfs entry
> * @name: flow handler name for /proc/interrupts output
> */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on
On 06/15/2010 07:10 AM, Konrad Rzeszutek Wilk wrote:
>> @@ -169,6 +170,7 @@ struct irq_2_iommu;
>> * @pending_mask: pending rebalanced interrupts
>> * @threads_active: number of irqaction threads currently running
>> * @wait_for_threads: wait queue for sync_irq to wait for threaded handlers
>> + * @poll_timer: timer for IRQ polling
>
> I looked over the patches and they all look good to my eyes.
>
> The only thing that looked out of place was the above comment.
> Would it make sense to move the comment one tab to the left?

When applied, it will show up at the right place. It's because the
first tab ends next to ':' and the leading '+' ends up pushing it to
the next tab position.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/