Prev: [git pull] spi driver changes
Next: ipv4: udp: fix short packet and bad checksum logging
From: Jeff Kirsher on 25 May 2010 03:20
On Mon, May 10, 2010 at 17:46, Jeff Kirsher <jeffrey.t.kirsher(a)intel.com> wrote:
> From: Jesse Brandeburg <jesse.brandeburg(a)intel.com>
>
> backporting this commit:
>
> commit fdd3d631cddad20ad9d3e1eb7dbf26825a8a121f
> Author: Krishna Kumar <krkumar2(a)in.ibm.com>
> Date:   Wed Feb 3 13:13:10 2010 +0000
>
>    ixgbe: Fix return of invalid txq
>
>    a developer had complained of getting lots of warnings:
>
>    "eth16 selects TX queue 98, but real number of TX queues is 64"
>
>    http://www.mail-archive.com/e1000-devel(a)lists.sourceforge.net/msg02200.html
>
>    As there was no follow up on that bug, I am submitting this
>    patch assuming that the other return points will not return
>    invalid txq's, and also that this fixes the bug (not tested).
>
>    Signed-off-by: Krishna Kumar <krkumar2(a)in.ibm.com>
>    Signed-off-by: Jesse Brandeburg <jesse.brandeburg(a)intel.com>
>    Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr(a)intel.com>
>    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com>
>    Signed-off-by: David S. Miller <davem(a)davemloft.net>
>
> CC: Brandon <brandon(a)ifup.org>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg(a)intel.com>
> ---
>
>  drivers/net/ixgbe/ixgbe_main.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>

Greg - status? Did you queue this patch for the stable release and I missed it?

--
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Brandeburg, Jesse on 25 May 2010 13:00


On Tue, 25 May 2010, Jeff Kirsher wrote:

> On Mon, May 10, 2010 at 17:46, Jeff Kirsher <jeffrey.t.kirsher(a)intel.com> wrote:
> > From: Jesse Brandeburg <jesse.brandeburg(a)intel.com>
> >
> > backporting this commit:
> >
> > commit fdd3d631cddad20ad9d3e1eb7dbf26825a8a121f
> > Author: Krishna Kumar <krkumar2(a)in.ibm.com>
> > Date:   Wed Feb 3 13:13:10 2010 +0000
> >
> >    ixgbe: Fix return of invalid txq
> >
> >    a developer had complained of getting lots of warnings:
> >
> >    "eth16 selects TX queue 98, but real number of TX queues is 64"
> >
> >    http://www.mail-archive.com/e1000-devel(a)lists.sourceforge.net/msg02200.html
> >
> >    As there was no follow up on that bug, I am submitting this
> >    patch assuming that the other return points will not return
> >    invalid txq's, and also that this fixes the bug (not tested).
> >
> >    Signed-off-by: Krishna Kumar <krkumar2(a)in.ibm.com>
> >    Signed-off-by: Jesse Brandeburg <jesse.brandeburg(a)intel.com>
> >    Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr(a)intel.com>
> >    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com>
> >    Signed-off-by: David S. Miller <davem(a)davemloft.net>
> >
> > CC: Brandon <brandon(a)ifup.org>
> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg(a)intel.com>
> > ---
> >
> >  drivers/net/ixgbe/ixgbe_main.c |    8 ++++++--
> >  1 files changed, 6 insertions(+), 2 deletions(-)
> >
>
> Greg - status? Did you queue this patch for the stable release and I missed it?

Maybe we didn't say (and we should have) that this fixes a panic on
machines with > 64 cores. Please apply to -stable 32.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [git pull] spi driver changes
Next: ipv4: udp: fix short packet and bad checksum logging