From: David Miller on

Can you please indicate which tree this is against when you post these
patches?

They don't apply cleanly to Linus's current tree which is where I tend
to try first when the tree is unspecified, as I imagine others do as
well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jason Baron on
On Wed, Jul 28, 2010 at 12:34:27PM -0700, David Miller wrote:
> Can you please indicate which tree this is against when you post these
> patches?
>
> They don't apply cleanly to Linus's current tree which is where I tend
> to try first when the tree is unspecified, as I imagine others do as
> well.
>

Hi,

Patches are against Ingo's latest -tip tree.

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on
From: Jason Baron <jbaron(a)redhat.com>
Date: Wed, 28 Jul 2010 16:14:59 -0400

> Patches are against Ingo's latest -tip tree.

After applying patch #5:

kernel/kprobes.c: In function 'register_kprobe':
kernel/kprobes.c:1145:6: error: implicit declaration of function 'jump_label_text_reserved'
make[1]: *** [kernel/kprobes.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [kernel] Error 2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jason Baron on
On Wed, Jul 28, 2010 at 01:24:27PM -0700, David Miller wrote:
> > Patches are against Ingo's latest -tip tree.
>
> After applying patch #5:
>
> kernel/kprobes.c: In function 'register_kprobe':
> kernel/kprobes.c:1145:6: error: implicit declaration of function 'jump_label_text_reserved'
> make[1]: *** [kernel/kprobes.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [kernel] Error 2

ok,

Not sure exactly what your .config is, but pulling in jump_label.h
explicitly into kprobes.c should fix that. if it doesn't please post
your .config.


diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 2f9bea6..a53bff3 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -47,6 +47,7 @@
#include <linux/memory.h>
#include <linux/ftrace.h>
#include <linux/cpu.h>
+#include <linux/jump_label.h>

#include <asm-generic/sections.h>
#include <asm/cacheflush.h>

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on
From: Jason Baron <jbaron(a)redhat.com>
Date: Wed, 28 Jul 2010 16:42:26 -0400

> Not sure exactly what your .config is,

arch/sparc/configs/sparc64_defconfig with tracepoints and the function
graph tracer enabled

> but pulling in jump_label.h explicitly into kprobes.c should fix
> that.

Yes, it does.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/