kbuild: Warn on selecting symbols with unmet direct dependencies
in [Kernel]
|
Prev: KVM: MMU: don't mark pte notrap if it's just sync transient
Next: [PATCH 2/6]kernel:audit.c Fix warning: variable 'nlh' set but not used
From: Randy Dunlap on 11 Jun 2010 16:40 On Tue, 08 Jun 2010 17:25:57 +0100 Catalin Marinas wrote: > The "select" statement in Kconfig files allows the enabling of options > even if they have unmet direct dependencies (i.e. "depends on" expands > to "no"). Currently, the "depends on" clauses are used in calculating > the visibility but they do not affect the reverse dependencies in any > way. > > The patch introduces additional tracking of the "depends on" statements > and prints a warning on selecting an option if its direct dependencies > are not met. Hi Catalin, Can these messages (on linux-next-20100611) be modified to include the kconfig symbol that is causing them? warning: (IP_VS_PROTO_ESP && NET && NETFILTER && IP_VS || IP_VS_PROTO_AH && NET && NETFILTER && IP_VS) selects IP_VS_PROTO_AH_ESP which has unmet direct dependencies (UNDEFINED) warning: (SCx200_GPIO && SCx200 || PC8736x_GPIO && X86) selects NSC_GPIO which has unmet direct dependencies (X86_32) Ah! It's the first symbol listed in each "phrase": SCx200_GPIO and PC8736x_GPIO both have this problem. (I haven't looked at IP_VS yet). Jordan, is GEODE always 32-bit, so that some of these dependencies could be cleaned up by using X86_32? thanks, --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Catalin Marinas on 16 Jun 2010 12:40 On Fri, 2010-06-11 at 21:31 +0100, Randy Dunlap wrote: > On Tue, 08 Jun 2010 17:25:57 +0100 Catalin Marinas wrote: > > > The "select" statement in Kconfig files allows the enabling of options > > even if they have unmet direct dependencies (i.e. "depends on" expands > > to "no"). Currently, the "depends on" clauses are used in calculating > > the visibility but they do not affect the reverse dependencies in any > > way. > > > > The patch introduces additional tracking of the "depends on" statements > > and prints a warning on selecting an option if its direct dependencies > > are not met. > > Can these messages (on linux-next-20100611) be modified to include the > kconfig symbol that is causing them? > > warning: (IP_VS_PROTO_ESP && NET && NETFILTER && IP_VS || > IP_VS_PROTO_AH && NET && NETFILTER && IP_VS) selects > IP_VS_PROTO_AH_ESP which has unmet direct dependencies (UNDEFINED) > warning: (SCx200_GPIO && SCx200 || PC8736x_GPIO && X86) selects > NSC_GPIO which has unmet direct dependencies (X86_32) > > Ah! It's the first symbol listed in each "phrase": (sorry for the delay) It is usually the first symbol though kbuild does some expression reduction when calculating the dependencies and I can't guarantee that it is always the case. It's probably for someone who understands kbuild better then me to make the output easier to read. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andres Salomon on 28 Jun 2010 22:30
On Fri, 11 Jun 2010 13:31:19 -0700 Randy Dunlap <randy.dunlap(a)oracle.com> wrote: > On Tue, 08 Jun 2010 17:25:57 +0100 Catalin Marinas wrote: > > > The "select" statement in Kconfig files allows the enabling of options > > even if they have unmet direct dependencies (i.e. "depends on" expands > > to "no"). Currently, the "depends on" clauses are used in calculating > > the visibility but they do not affect the reverse dependencies in any > > way. > > > > The patch introduces additional tracking of the "depends on" statements > > and prints a warning on selecting an option if its direct dependencies > > are not met. > > > Hi Catalin, > > Can these messages (on linux-next-20100611) be modified to include the > kconfig symbol that is causing them? > > warning: (IP_VS_PROTO_ESP && NET && NETFILTER && IP_VS || IP_VS_PROTO_AH && NET && NETFILTER && IP_VS) selects IP_VS_PROTO_AH_ESP which has unmet direct dependencies (UNDEFINED) > warning: (SCx200_GPIO && SCx200 || PC8736x_GPIO && X86) selects NSC_GPIO which has unmet direct dependencies (X86_32) > > Ah! It's the first symbol listed in each "phrase": > > SCx200_GPIO and PC8736x_GPIO both have this problem. > (I haven't looked at IP_VS yet). It's unclear why NSC_GPIO depends upon X86_32 (davej sent the patch, 699352c30da8525a). While geode stuff will probably only ever exist on x86, there's nothing in the driver that's X86_32-specific. > > Jordan, is GEODE always 32-bit, so that some of these dependencies could be > cleaned up by using X86_32? Sadly, I don't think Jordan tracks this list any more. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |