kbuild: include only necessary in scripts/Makefile.modbuiltin
in [Kernel]
|
Prev: [PATCH v3 0/4] i2c: davinci: Add power management features
Next: [PATCH v2 2/2] davinci: MMC: updates to suspend/resume implementation
From: Michal Marek on 6 Jan 2010 05:00 On 6.1.2010 07:26, Eric Miao wrote: > scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in > every sub-directory, which is not true. It assumes what there is a kbuild file in each directory listed in subdir-[ym] or obj-[ym]. For which directory is this not true? Did you see an actual build failure? The same include is used in scripts/Makefile.build, where it has been working fine for ages... Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Eric Miao on 6 Jan 2010 05:40 On Wed, Jan 6, 2010 at 5:51 PM, Michal Marek <mmarek(a)suse.cz> wrote: > On 6.1.2010 07:26, Eric Miao wrote: >> scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in >> every sub-directory, which is not true. > > It assumes what there is a kbuild file in each directory listed in > subdir-[ym] or obj-[ym]. For which directory is this not true? Did you > see an actual build failure? The same include is used in > scripts/Makefile.build, where it has been working fine for ages... > Well, it's in my tree outside mainline, I have to make this change to get it build. And'm wondering if that's a correct assumption. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michal Marek on 6 Jan 2010 05:40 On 6.1.2010 11:31, Eric Miao wrote: > On Wed, Jan 6, 2010 at 5:51 PM, Michal Marek <mmarek(a)suse.cz> wrote: >> On 6.1.2010 07:26, Eric Miao wrote: >>> scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in >>> every sub-directory, which is not true. >> >> It assumes what there is a kbuild file in each directory listed in >> subdir-[ym] or obj-[ym]. For which directory is this not true? Did you >> see an actual build failure? The same include is used in >> scripts/Makefile.build, where it has been working fine for ages... >> > > Well, it's in my tree outside mainline, I have to make this change > to get it build. And'm wondering if that's a correct assumption. And scripts/Makefile.build does not fail? Strange. Can you point me at the tree so that I can have a look? I assume it's some branch of git://git.kernel.org/pub/scm/linux/kernel/git/ycmiao/pxa-linux-2.6.git. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Eric Miao on 6 Jan 2010 06:30 On Wed, Jan 6, 2010 at 6:39 PM, Michal Marek <mmarek(a)suse.cz> wrote: > On 6.1.2010 11:31, Eric Miao wrote: >> On Wed, Jan 6, 2010 at 5:51 PM, Michal Marek <mmarek(a)suse.cz> wrote: >>> On 6.1.2010 07:26, Eric Miao wrote: >>>> scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in >>>> every sub-directory, which is not true. >>> >>> It assumes what there is a kbuild file in each directory listed in >>> subdir-[ym] or obj-[ym]. For which directory is this not true? Did you >>> see an actual build failure? The same include is used in >>> scripts/Makefile.build, where it has been working fine for ages... >>> >> >> Well, it's in my tree outside mainline, I have to make this change >> to get it build. And'm wondering if that's a correct assumption. > > And scripts/Makefile.build does not fail? Strange. Can you point me at > the tree so that I can have a look? I assume it's some branch of > git://git.kernel.org/pub/scm/linux/kernel/git/ycmiao/pxa-linux-2.6.git. > No, it's not within that tree. And indeed it's strange - while scripts/Makefile.build doesn't fail since there seems to be a script that generates some Makefiles in between the build process, I'll get this figured out to see what is the root cause. > Thanks, > Michal > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michal Marek on 6 Jan 2010 06:50
On 6.1.2010 12:22, Eric Miao wrote: > And indeed it's strange - while scripts/Makefile.build doesn't fail since > there seems to be a script that generates some Makefiles in between > the build process, I'll get this figured out to see what is the root > cause. Oh. If that turns out to be the cause and the script is going to stay, then the right fix would be to change the toplevel Makefile generate the modules.builtin files in a separate target after the build, and not in parallel. I planed to do this change anyway, to later avoid regenerating the modules.builtin files if the config didn't change. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |