kernel: local_irq_{save,restore}_nmi()
in [Kernel]
|
Prev: ahci 0000:00:1f.2: controller reset failed (0xffffffff)
Next: [PATCH][GIT PULL] tracing/mac80211: Move TRACE_SYSTEM out of #if protection
From: David Miller on 6 Apr 2010 21:20 From: Steven Rostedt <rostedt(a)goodmis.org> Date: Tue, 06 Apr 2010 21:13:10 -0400 > On Tue, 2010-04-06 at 15:28 +0200, Peter Zijlstra wrote: > >> Index: linux-2.6/kernel/trace/trace_irqsoff.c >> =================================================================== >> --- linux-2.6.orig/kernel/trace/trace_irqsoff.c >> +++ linux-2.6/kernel/trace/trace_irqsoff.c >> @@ -316,6 +316,14 @@ void trace_hardirqs_off(void) >> } >> EXPORT_SYMBOL(trace_hardirqs_off); >> >> +void trace_hardirqs_off_no_nmi(void) >> +{ >> + WARN_ON_ONCE(in_nmi()); > > Should we do this for all archs? I can imagine a lot of warning reports > coming in the near future. And they will be passing it towards me. That's the whole point, so that the problem is more easily noticed and it gets fixed long before I end up accidently testing the code on my machines :-) To be honest, the fix is so trivial, you just need to add '_nmi' to the local_irq_{save,restore}() calls that warn like this. I'm even willing to have you forward all of those reports to me and I'll be responsible for fixing them. How's that? :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Steven Rostedt on 6 Apr 2010 21:20 On Tue, 2010-04-06 at 15:28 +0200, Peter Zijlstra wrote: > Index: linux-2.6/kernel/trace/trace_irqsoff.c > =================================================================== > --- linux-2.6.orig/kernel/trace/trace_irqsoff.c > +++ linux-2.6/kernel/trace/trace_irqsoff.c > @@ -316,6 +316,14 @@ void trace_hardirqs_off(void) > } > EXPORT_SYMBOL(trace_hardirqs_off); > > +void trace_hardirqs_off_no_nmi(void) > +{ > + WARN_ON_ONCE(in_nmi()); Should we do this for all archs? I can imagine a lot of warning reports coming in the near future. And they will be passing it towards me. -- Steve > + if (!preempt_trace() && irq_trace()) > + start_critical_timing(CALLER_ADDR0, CALLER_ADDR1); > +} > +EXPORT_SYMBOL(trace_hardirqs_off_no_nmi); > + > void trace_hardirqs_on_caller(unsigned long caller_addr) > { > if (!preempt_trace() && irq_trace()) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Steven Rostedt on 6 Apr 2010 21:30
On Tue, 2010-04-06 at 18:19 -0700, David Miller wrote: > That's the whole point, so that the problem is more easily noticed and > it gets fixed long before I end up accidently testing the code on my > machines :-) > > To be honest, the fix is so trivial, you just need to add '_nmi' to > the local_irq_{save,restore}() calls that warn like this. > > I'm even willing to have you forward all of those reports to me and > I'll be responsible for fixing them. > > How's that? :-) Sure. /me sets up his procmailrc to search for the WARN_ON line in trace_irqsoff.c and have it forward to davem. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |