Prev: [PATCH] x86/pat: fix memory leak in free_memtype
Next: [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF
From: Eric W. Biederman on 25 May 2010 06:30
Dan Carpenter <error27(a)gmail.com> writes:

> There is a kfree(ue_sk) missing on the error path if
> netlink_kernel_create() fails.
>
> Signed-off-by: Dan Carpenter <error27(a)gmail.com>
Reviewed-by: "Eric W. Biederman" <ebiederm(a)xmission.com>

Oops.

> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index 59c1551..08e15f7 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -378,6 +378,7 @@ static int uevent_net_init(struct net *net)
> if (!ue_sk->sk) {
> printk(KERN_ERR
> "kobject_uevent: unable to create netlink socket!\n");
> + kfree(ue_sk);
> return -ENODEV;
> }
> mutex_lock(&uevent_sock_mutex);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 26 May 2010 03:50
From: ebiederm(a)xmission.com (Eric W. Biederman)
Date: Tue, 25 May 2010 03:25:37 -0700

> Dan Carpenter <error27(a)gmail.com> writes:
>
>> There is a kfree(ue_sk) missing on the error path if
>> netlink_kernel_create() fails.
>>
>> Signed-off-by: Dan Carpenter <error27(a)gmail.com>
> Reviewed-by: "Eric W. Biederman" <ebiederm(a)xmission.com>

Greg, I assume you've got this one?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 26 May 2010 11:00
On Wed, May 26, 2010 at 12:43:47AM -0700, David Miller wrote:
> From: ebiederm(a)xmission.com (Eric W. Biederman)
> Date: Tue, 25 May 2010 03:25:37 -0700
>
> > Dan Carpenter <error27(a)gmail.com> writes:
> >
> >> There is a kfree(ue_sk) missing on the error path if
> >> netlink_kernel_create() fails.
> >>
> >> Signed-off-by: Dan Carpenter <error27(a)gmail.com>
> > Reviewed-by: "Eric W. Biederman" <ebiederm(a)xmission.com>
>
> Greg, I assume you've got this one?

Yes, I'll queue it up in a day or so.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] x86/pat: fix memory leak in free_memtype
Next: [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF