Prev: [PATCH 2/3 ] SCSI: Support 1024 scatter-gather list entries and improve AP while FW trapped and behaviors of EHs
Next: watchdog: ep93xx_wdt.c - fix module-param-desc.
From: Alberto Panizzo on 3 May 2010 04:10
On lun, 2010-05-03 at 14:42 +0800, Axel Lin wrote:
> This patch includes below fixes for properly error handling:
> 1. In the case of kzalloc failure, simple return -ENOMEM instead of goto
> err. ( priv is NULL in this case )
> 2. In the case of gpio_request fail for reset_gpio and data_enable_gpio,
> properly release resources by goto err and err2 respectively.
>
> Signed-off-by: Axel Lin <axel.lin(a)gmail.com>

Tank you for these fixes!

Acked-by: Alberto Panizzo <maramaopercheseimorto(a)gmail.com>

Alberto!

> ---
> drivers/video/backlight/l4f00242t03.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c
> b/drivers/video/backlight/l4f00242t03.c
> index bcdb12c..a4632db 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -125,8 +125,7 @@ static int __devinit l4f00242t03_probe(struct
> spi_device *spi)
>
> if (priv == NULL) {
> dev_err(&spi->dev, "No memory for this device.\n");
> - ret = -ENOMEM;
> - goto err;
> + return -ENOMEM;
> }
>
> dev_set_drvdata(&spi->dev, priv);
> @@ -139,7 +138,7 @@ static int __devinit l4f00242t03_probe(struct
> spi_device *spi)
> if (ret) {
> dev_err(&spi->dev,
> "Unable to get the lcd l4f00242t03 reset gpio.\n");
> - return ret;
> + goto err;
> }
>
> ret = gpio_direction_output(pdata->reset_gpio, 1);
> @@ -151,7 +150,7 @@ static int __devinit l4f00242t03_probe(struct
> spi_device *spi)
> if (ret) {
> dev_err(&spi->dev,
> "Unable to get the lcd l4f00242t03 data en gpio.\n");
> - return ret;
> + goto err2;
> }
>
> ret = gpio_direction_output(pdata->data_enable_gpio, 0);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/3 ] SCSI: Support 1024 scatter-gather list entries and improve AP while FW trapped and behaviors of EHs
Next: watchdog: ep93xx_wdt.c - fix module-param-desc.