leds-lp3944: properly handle lp3944_configure fail in lp3944_probe
in [Kernel]
|
Prev: kvm network problem with Solaris 10u8 guest
Next: [PATCH] perf: fix bug mismatch with -c option definition
From: Antonio Ospite on 17 May 2010 06:30 On Mon, 17 May 2010 17:47:48 +0800 Axel Lin <axel.lin(a)gmail.com> wrote: > In current implementation, lp3944_probe return 0 even if lp3944_configure fail. > Therefore, led_classdev_unregister will be executed twice > ( in error handling of lp3944_configure and lp3944_remove ). > This patch properly handles lp3944_configure fail in lp3944_probe. > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Acked-by: Antonio Ospite <ospite(a)studenti.unina.it> Thanks. -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
From: Richard Purdie on 26 May 2010 07:40
On Mon, 2010-05-17 at 12:15 +0200, Antonio Ospite wrote: > On Mon, 17 May 2010 17:47:48 +0800 > Axel Lin <axel.lin(a)gmail.com> wrote: > > > In current implementation, lp3944_probe return 0 even if lp3944_configure fail. > > Therefore, led_classdev_unregister will be executed twice > > ( in error handling of lp3944_configure and lp3944_remove ). > > This patch properly handles lp3944_configure fail in lp3944_probe. > > > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > > Acked-by: Antonio Ospite <ospite(a)studenti.unina.it> > Queued in the leds tree, thanks. Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |