Prev: [PATCH] TPM: ACPI/PNP dependency removal
Next: [GIT PULL 0/4] perf tools fixes
From: Andrew Morton on 13 May 2010 16:30
On Thu, 13 May 2010 01:17:24 +0400
"Denis Kirjanov <kirjanov(a)gmail.com" <kirjanov(a)gmail.com> wrote:

> Kill unused MAX macro
>
> Signed-off-by: Denis Kirjanov <kirjanov(a)gmail.com>
> ---
> diff --git a/lib/btree.c b/lib/btree.c
> index 41859a8..f833949 100644
> --- a/lib/btree.c
> +++ b/lib/btree.c
> @@ -45,7 +45,6 @@
> #include <linux/slab.h>
> #include <linux/module.h>
>
> -#define MAX(a, b) ((a) > (b) ? (a) : (b))

It's used on the very next line:

> #define NODESIZE MAX(L1_CACHE_BYTES, 128)

And we cannot use max() here because it's evaluated at compile-time.


Also, this reader is quite unable to determine why this forumation for
NODESIZE was chosen. As few kernel programmers can read Joern's mind,
I'd suggest that a code comment is in order.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jörn Engel on 14 May 2010 13:10
On Thu, 13 May 2010 13:24:34 -0700, Andrew Morton wrote:
>
> Also, this reader is quite unable to determine why this forumation for
> NODESIZE was chosen. As few kernel programmers can read Joern's mind,
> I'd suggest that a code comment is in order.

Ack. I'm currently on vacation, so it will have to wait until next
week.

Jörn

--
Unless something dramatically changes, by 2015 we'll be largely
wondering what all the fuss surrounding Linux was really about.
-- Rob Enderle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] TPM: ACPI/PNP dependency removal
Next: [GIT PULL 0/4] perf tools fixes