linux-next: April 27 (iscsi_ibft)
in [Kernel]
|
From: Randy Dunlap on 27 Apr 2010 12:20 when CONFIG_ACPI is not enabled: drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Konrad Rzeszutek Wilk on 27 Apr 2010 19:10 On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote: > when CONFIG_ACPI is not enabled: > > drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type > drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type > drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' > drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type > drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' Yikes. Randy, thank you for spotting this and sending an e-mail my way. It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which is gone when !CONFIG_ACPI. Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included a copy of the old ibft_struct that should work. Or we make the code dependent on CONFIG_ACPI (in the Kconfig file). Peter, Randy: Which option do you think makes more sense? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 28 Apr 2010 11:30 On 04/27/10 16:01, Konrad Rzeszutek Wilk wrote: > On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote: >> when CONFIG_ACPI is not enabled: >> >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' > > Yikes. > > Randy, thank you for spotting this and sending an e-mail my way. > > It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which > is gone when !CONFIG_ACPI. > > Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included > a copy of the old ibft_struct that should work. > > Or we make the code dependent on CONFIG_ACPI (in the Kconfig > file). > > Peter, Randy: Which option do you think makes more sense? I think that you and Peter know more about that than I do. I'd go for the Kconfig dependency. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Peter Jones on 3 May 2010 12:10 On 04/27/2010 07:01 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote: >> when CONFIG_ACPI is not enabled: >> >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' > > Yikes. > > Randy, thank you for spotting this and sending an e-mail my way. > > It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which > is gone when !CONFIG_ACPI. > > Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included > a copy of the old ibft_struct that should work. > > Or we make the code dependent on CONFIG_ACPI (in the Kconfig > file). > > Peter, Randy: Which option do you think makes more sense? Or we make that one structure be defined whether CONFIG_ACPI is enabled or not. -- Peter For some reason it has always seemed to me that the term software engineering contains some very optimistic assumptions about the nature of reality. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Konrad Rzeszutek Wilk on 11 May 2010 15:00 > > It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which > > is gone when !CONFIG_ACPI. > > > > Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included > > a copy of the old ibft_struct that should work. > > > > Or we make the code dependent on CONFIG_ACPI (in the Kconfig > > file). > > > > Peter, Randy: Which option do you think makes more sense? > > I think that you and Peter know more about that than I do. > I'd go for the Kconfig dependency. Found a way that makes this go away. This is by including #include <linux/iscsi_ibft.h> in the module and it fixed the problem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: [ANNOUNCE] 2.6.33.3-rt16 Next: linux-next: April 27 (mm/page-writeback) |