From: Stephen Rothwell on
Hi Greg,

After merging the tty tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/serial/mfd.c:37:30: error: linux/serial_mfd.h: No such file or directory
drivers/serial/mfd.c: In function 'port_show_regs':
drivers/serial/mfd.c:166: error: 'UART_FOR' undeclared (first use in this function)

.... and on ... and on ...

Caused by commit c3190cf68dfc58c33de0fd59b919cbb864acbba4 ("hsu: driver
for Medfield High Speed UART device") and following. Did it miss a file?

A little more care and testing, please.

I reverted that commit and the following three that depend on it.
--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Alan Cox on
On Tue, 27 Jul 2010 15:18:43 +1000
Stephen Rothwell <sfr(a)canb.auug.org.au> wrote:

> Hi Greg,
>
> After merging the tty tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/serial/mfd.c:37:30: error: linux/serial_mfd.h: No such file or directory
> drivers/serial/mfd.c: In function 'port_show_regs':
> drivers/serial/mfd.c:166: error: 'UART_FOR' undeclared (first use in this function)
>
> ... and on ... and on ...
>
> Caused by commit c3190cf68dfc58c33de0fd59b919cbb864acbba4 ("hsu: driver
> for Medfield High Speed UART device") and following. Did it miss a file?
>
> A little more care and testing, please.

Yes although I had a local copy so it built and tested beautifully 8(

Will send Greg and updated set of those patches versus todays -next
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on
On Tue, Jul 27, 2010 at 08:43:53AM +0100, Alan Cox wrote:
> On Tue, 27 Jul 2010 15:18:43 +1000
> Stephen Rothwell <sfr(a)canb.auug.org.au> wrote:
>
> > Hi Greg,
> >
> > After merging the tty tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/serial/mfd.c:37:30: error: linux/serial_mfd.h: No such file or directory
> > drivers/serial/mfd.c: In function 'port_show_regs':
> > drivers/serial/mfd.c:166: error: 'UART_FOR' undeclared (first use in this function)
> >
> > ... and on ... and on ...
> >
> > Caused by commit c3190cf68dfc58c33de0fd59b919cbb864acbba4 ("hsu: driver
> > for Medfield High Speed UART device") and following. Did it miss a file?
> >
> > A little more care and testing, please.
>
> Yes although I had a local copy so it built and tested beautifully 8(
>
> Will send Greg and updated set of those patches versus todays -next

Now fixed up, sorry for missing this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stephen Rothwell on
Hi Greg, Alan,

On Tue, 27 Jul 2010 09:47:17 -0700 Greg KH <greg(a)kroah.com> wrote:
>
> On Tue, Jul 27, 2010 at 08:43:53AM +0100, Alan Cox wrote:
> >
> > Will send Greg and updated set of those patches versus todays -next
>
> Now fixed up, sorry for missing this.

Thanks guys.
--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/