linux-next: build warning after merge of the driver-core.current tree
in [Kernel]
|
Prev: [PATCH 03/10] usb: atm: speedtch: use new hex_to_bin() method
Next: staging: et131x: et1310_eeprom.c coding style fixes.
From: Stephen Rothwell on 30 Apr 2010 13:30 Hi Greg, On Thu, 29 Apr 2010 16:45:25 -0700 Greg KH <greg(a)kroah.com> wrote: > > > Thanks, I've fixed this up, the release call should not have 'const' > > on it as it is going to touch the pointer passed to it :) > > And it's now pushed out in my tree. Excellent, thanks. -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au http://www.canb.auug.org.au/~sfr/
From: Greg KH on 30 Apr 2010 13:40 On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote: > Hi Grant, > > After merging the driver-core.current tree, today's linux-next build > (x86_64 allmodconfig) produced this warning: > > drivers/base/firmware_class.c: In function 'release_firmware': > drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type > drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *' > > Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0 > ("firmware_class: fix memory leak - free allocated pages"). Thanks, I've fixed this up, the release call should not have 'const' on it as it is going to touch the pointer passed to it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 30 Apr 2010 13:40
On Thu, Apr 29, 2010 at 04:43:47PM -0700, Greg KH wrote: > On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote: > > Hi Grant, > > > > After merging the driver-core.current tree, today's linux-next build > > (x86_64 allmodconfig) produced this warning: > > > > drivers/base/firmware_class.c: In function 'release_firmware': > > drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type > > drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *' > > > > Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0 > > ("firmware_class: fix memory leak - free allocated pages"). > > Thanks, I've fixed this up, the release call should not have 'const' > on it as it is going to touch the pointer passed to it :) And it's now pushed out in my tree. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |