lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic
in [Kernel]
|
From: Mark Brown on 11 Mar 2010 06:10 On Thu, Mar 11, 2010 at 09:56:34AM +0800, axel lin wrote: > From 99175ed0f281d54efdaf8eef548077a8f0b4924a Mon Sep 17 00:00:00 2001 > From: Axel Lin <axel.lin(a)gmail.com> > Date: Thu, 11 Mar 2010 09:50:07 +0800 > Subject: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic > > Given x=0,1,2, current implementation of BUCK_VOL_CHANGE_SHIFT(x) returns 0,4,8. > The correct return value should be 0,4,6. > This patch fix the logic. > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> with the same comment about ideally wanting someone who worked on the driver previously to check stuff. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 11 Mar 2010 06:20 On Thu, 2010-03-11 at 11:04 +0000, Mark Brown wrote: > On Thu, Mar 11, 2010 at 09:56:34AM +0800, axel lin wrote: > > From 99175ed0f281d54efdaf8eef548077a8f0b4924a Mon Sep 17 00:00:00 2001 > > From: Axel Lin <axel.lin(a)gmail.com> > > Date: Thu, 11 Mar 2010 09:50:07 +0800 > > Subject: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic > > > > Given x=0,1,2, current implementation of BUCK_VOL_CHANGE_SHIFT(x) returns 0,4,8. > > The correct return value should be 0,4,6. > > This patch fix the logic. > > > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > > with the same comment about ideally wanting someone who worked on the > driver previously to check stuff. Marek, Kyungmin, could someone please test/ack this before both are applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Marek Szyprowski on 15 Mar 2010 03:00 Hello, On Thursday, March 11, 2010 12:18 PM Liam Girdwood wrote: > On Thu, 2010-03-11 at 11:04 +0000, Mark Brown wrote: > > On Thu, Mar 11, 2010 at 09:56:34AM +0800, axel lin wrote: > > > From 99175ed0f281d54efdaf8eef548077a8f0b4924a Mon Sep 17 00:00:00 2001 > > > From: Axel Lin <axel.lin(a)gmail.com> > > > Date: Thu, 11 Mar 2010 09:50:07 +0800 > > > Subject: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic > > > > > > Given x=0,1,2, current implementation of BUCK_VOL_CHANGE_SHIFT(x) returns 0,4,8. > > > The correct return value should be 0,4,6. > > > This patch fix the logic. > > > > > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > > > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > > > > with the same comment about ideally wanting someone who worked on the > > driver previously to check stuff. > > Marek, Kyungmin, could someone please test/ack this before both are > applied. Acked-by: Marek Szyprowski <m.szyprowski(a)samsung.com> Axel was right, my bit arithmetic was definitely wrong. Again, thanks for spotting it and I'm really sorry You had lost some time debugging it. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 17 Mar 2010 19:10 On Thu, 2010-03-11 at 09:56 +0800, axel lin wrote: > >From 99175ed0f281d54efdaf8eef548077a8f0b4924a Mon Sep 17 00:00:00 2001 > From: Axel Lin <axel.lin(a)gmail.com> > Date: Thu, 11 Mar 2010 09:50:07 +0800 > Subject: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic > > Given x=0,1,2, current implementation of BUCK_VOL_CHANGE_SHIFT(x) returns 0,4,8. > The correct return value should be 0,4,6. > This patch fix the logic. > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Both Applied with fixes for mailer mangled patches. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: davinci: MMC: Pass number of SG segments as platform data Next: (none) |