Prev: fasync: RCU and fine grained locking
Next: Ref Number 3XTA932CL9
From: David Miller on 21 Apr 2010 19:40
From: Finn Thain <fthain(a)telegraphics.com.au>
Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST)

>
> Change an error return code from -EAGAIN to -EBUSY since the former is
> misleading.
>
> Nubus slots are geographically addressed and their irqs are equally
> inflexible. -EAGAIN is misleading because retrying will not help fix
> whatever bug it was that made the irq unavailable.

request_irq() itself returns an appropriate error code, so the
correct change is to do:

err = request_irq( ... );
if (err) {
...

and return 'err'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Finn Thain on 21 Apr 2010 21:20

On Wed, 21 Apr 2010, David Miller wrote:

> From: Finn Thain <fthain(a)telegraphics.com.au>
> Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST)
>
> >
> > Change an error return code from -EAGAIN to -EBUSY since the former is
> > misleading.
> >
> > Nubus slots are geographically addressed and their irqs are equally
> > inflexible. -EAGAIN is misleading because retrying will not help fix
> > whatever bug it was that made the irq unavailable.
>
> request_irq() itself returns an appropriate error code, so the
> correct change is to do:
>
> err = request_irq( ... );
> if (err) {
> ...
>
> and return 'err'.

OK. I'll send a new patch once 2.6.34 is out and I have time to test this
and some other patches.

Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: fasync: RCU and fine grained locking
Next: Ref Number 3XTA932CL9