matroxfb: fix incorrect use of memcpy_toio()
in [Kernel]
|
Prev: [PATCH] ipw2100: register pm_qos request before registering pci driver
Next: [PATCH 1/5] scsi: megaraid_sas - Add Online Controller Reset to MegaRAID SAS driver
From: Andrew Morton on 11 Aug 2010 16:50 On Wed, 11 Aug 2010 22:27:42 +0200 Ondrej Zary <linux(a)rainbow-software.org> wrote: > Fix incorrect use of memcpy_toio() in matroxfb that broke in 2.6.34 on x86. > Thanks. What was incorrect about it? And what is the user-visible effect of this regression? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ondrej Zary on 11 Aug 2010 17:20
On Wednesday 11 August 2010 22:41:36 Andrew Morton wrote: > On Wed, 11 Aug 2010 22:27:42 +0200 > > Ondrej Zary <linux(a)rainbow-software.org> wrote: > > Fix incorrect use of memcpy_toio() in matroxfb that broke in 2.6.34 on > > x86. > > Thanks. > > What was incorrect about it? And what is the user-visible effect of > this regression? Screen is completely corrupted since 2.6.34. Bisection revealed that it's caused by commit 6175ddf06b6172046a329e3abfd9c901a43efd2e. H. Peter Anvin explained that memcpy_toio() does not copy data in 32bit chunks anymore on x86. See: http://lkml.org/lkml/2010/8/2/409 -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |