microblaze_v2: headers simple files - empty or redirect to asm-generic
in [Kernel]
|
Prev: [PATCH] IB/ehca: Change function return types to correct type.
Next: bootmem2: a memory block-oriented boot time allocator
From: Grant Likely on 5 May 2008 11:20 On Sun, May 4, 2008 at 8:34 PM, John Williams <john.williams(a)petalogix.com> wrote: > > > include/asm-microblaze/auxvec.h | 14 ++++++++++++++ > > include/asm-microblaze/cputime.h | 16 ++++++++++++++++ > > include/asm-microblaze/div64.h | 16 ++++++++++++++++ > > include/asm-microblaze/emergency-restart.h | 16 ++++++++++++++++ > > include/asm-microblaze/errno.h | 16 ++++++++++++++++ > > include/asm-microblaze/futex.h | 16 ++++++++++++++++ > > include/asm-microblaze/kdebug.h | 19 +++++++++++++++++++ > > include/asm-microblaze/local.h | 16 ++++++++++++++++ > > include/asm-microblaze/mutex.h | 16 ++++++++++++++++ > > include/asm-microblaze/namei.h | 24 ++++++++++++++++++++++++ > > include/asm-microblaze/percpu.h | 16 ++++++++++++++++ > > include/asm-microblaze/resource.h | 16 ++++++++++++++++ > > include/asm-microblaze/user.h | 18 ++++++++++++++++++ > > These are all just includes of asm-generic/* (hooray!). > > But, is it reasonable to to suggest adding asm-generic at the end of the > kernel include path, and save all this verbosity? > > Principle of least surprise maybe? Convention in the other archs is already established to explicitly include asm-generic files one by one. It is probably best to match existing convention for commonality sake. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on 6 May 2008 05:10 On Monday 05 May 2008, Grant Likely wrote: > > �These are all just includes of asm-generic/* (hooray!). > > > > �But, is it reasonable to to suggest adding asm-generic at the end of the > > �kernel include path, and save all this verbosity? > > > > �Principle of least surprise maybe? > > Convention in the other archs is already established to explicitly > include asm-generic files one by one. �It is probably best to match > existing convention for commonality sake. Right, I agree. We may eventually want to move to something more sophisticated, but we should not change the current way of doing this while we're in the process of adding a new architecture. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Grant Likely on 6 May 2008 11:40 On Tue, May 6, 2008 at 9:23 AM, Michal Simek <monstr(a)seznam.cz> wrote: > Hi, > > > > > On Mon, 05 May 2008 12:34:09 +1000 John Williams <john.williams(a)petalogix.com> wrote: > >> > >>> include/asm-microblaze/auxvec.h | 14 ++++++++++++++ > >>> include/asm-microblaze/cputime.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/div64.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/emergency-restart.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/errno.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/futex.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/kdebug.h | 19 +++++++++++++++++++ > >>> include/asm-microblaze/local.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/mutex.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/namei.h | 24 ++++++++++++++++++++++++ > >>> include/asm-microblaze/percpu.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/resource.h | 16 ++++++++++++++++ > >>> include/asm-microblaze/user.h | 18 ++++++++++++++++++ > >> These are all just includes of asm-generic/* (hooray!). > > > > Absolutely, but is it really necessary to have 14-16 lines of comment > > (including a copyright notice) for a file whose single real line is just > > to include another file? i.e. reduce all these to 1 line files. > > Can I do it? I think every file need license. Its pretty hard to claim copyright rights on a single source line of code. :-) Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on 6 May 2008 12:30
On Tuesday 06 May 2008, Michal Simek wrote: > > > Absolutely, but is it really necessary to have 14-16 lines of comment > > (including a copyright notice) for a file whose single real line is just > > to include another file? �i.e. reduce all these to 1 line files. > > Can I do it? I think every file need license. If you want a good answer on that, ask your lawyer. In general, every file comes with a 'license' (GPLv2) and 'copyright' (you or the person you copied from) even if you don't put either statement in the file. Files smaller than some 10 lines are usually not considered to be covered by copyright, even if you have the statement in there. Most files nowadays are written by large corporations that have strict rules about what you must put in there to protect their intellectual property. It's certainly safe to leave out the file names from the comments, they don't add any value at all. Similarly, you should easily be able to leave out the license statement, unless you are under a contract that forces you to leave them present. Most people here will be happier if you remove the license statements. The most tricky one part is the copyright statement ("Copyright 2012 Big Corporation of America"), which you strictly speaking should never remove from a file unless you have permission from the copyright holder. Many of your files in your patch set are obviously copies of existing kernel files, with the original copyright notice replaced with "Atmark Techno, inc.". You can draw your own conclusions from that ;-) Obviously, I am not a lawyer, so don't consider this as legal advice. I really hope this doesn't turn into a flamewar, as discussions on intellectual property sometimes do. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |