Prev: posix_timer: clean up properly if anything fails after *_timer_create
Next: pcmcia: disable pcmcia ioctl for !ARM, prepare for removal
From: KOSAKI Motohiro on 15 May 2010 10:40
Hi

Mysteriously, I haven't receive original post.
So now I'm guessing you acked following patch.

http://lkml.org/lkml/2010/5/14/393

but I don't think it is correct.

> - check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
> + check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask,
> flags | MPOL_MF_DISCONTIG_OK, &pagelist);

Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform?
Please put following line anywhere.

#define TASK_SIZE_MAX TASK_SIZE


But this patch is conceptually good. if it fixes the bug. I'll ack gladly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg Thelen on 15 May 2010 18:50
On Sat, May 15, 2010 at 7:31 AM, KOSAKI Motohiro
<kosaki.motohiro(a)jp.fujitsu.com> wrote:
>
> Hi
>
> Mysteriously, I haven't receive original post.
> So now I'm guessing you acked following patch.
>
> http://lkml.org/lkml/2010/5/14/393
>
> but I don't think it is correct.
>
> > - � � check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
> > + � � check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask,
> > � � � � � � � � � � � flags | MPOL_MF_DISCONTIG_OK, &pagelist);
>
> Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform?
> Please put following line anywhere.
>
> #define TASK_SIZE_MAX TASK_SIZE

I just send out patch v2, which uses mm->task_size rather than
TASK_SIZE_MAX. Some non-x86 architectures do not define
TASK_SIZE_MAX, but do make TASK_SIZE depend on the current task. So I
feel it would be better to refer to the mm struct to obtain the needed
address space limit information rather than TASK_SIZE[_MAX], which can
depend on current.

--
Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: posix_timer: clean up properly if anything fails after *_timer_create
Next: pcmcia: disable pcmcia ioctl for !ARM, prepare for removal