From: Christoph Hellwig on
On Mon, Jun 14, 2010 at 01:58:18PM +0530, Srikar Dronamraju wrote:
> move_replace_page.patch
>
> From: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com>
>
> Move replace_page() and write_protect_page() to mm/memory.c
>
> User bkpt will use background page replacement approach to insert/delete
> breakpoints. Background page replacement approach will be based on
> replace_page and write_protect_page.
> Now replace_page() loses its static attribute.

Neither of these actually gets used in this series. So you can drop
the patch for now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Srikar Dronamraju on
> On Mon, Jun 14, 2010 at 01:58:18PM +0530, Srikar Dronamraju wrote:
> > move_replace_page.patch
> >
> > From: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com>
> >
> > Move replace_page() and write_protect_page() to mm/memory.c
> >
> > User bkpt will use background page replacement approach to insert/delete
> > breakpoints. Background page replacement approach will be based on
> > replace_page and write_protect_page.
> > Now replace_page() loses its static attribute.
>
> Neither of these actually gets used in this series. So you can drop
> the patch for now.

replace_page() and write_protect_page() are used in write_opcode() to
insert/remove a breakpoint in the user-space breakpoint insertion layer.
i.e "[PATCH v5 3/14] User Space Breakpoint Assistance Layer"

Even if we merge uprobes and user_bkpt layers, we would still need
write_opcode function while inserting/deleting a breakpoint.

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on
On Tue, Jun 15, 2010 at 09:30:01AM +0530, Srikar Dronamraju wrote:
> replace_page() and write_protect_page() are used in write_opcode() to
> insert/remove a breakpoint in the user-space breakpoint insertion layer.
> i.e "[PATCH v5 3/14] User Space Breakpoint Assistance Layer"

You're right. I did a git-grep, but that didn't find the newly added
files..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/