Prev: [PATCH] Disable i8042 checks on Intel Apple Macs
Next: [PATCH 1/4] MFD: pcf50633: Fix bitfield logic in interrupt handler
From: KOSAKI Motohiro on 11 May 2010 20:30
> diff --git a/fs/exec.c b/fs/exec.c
> index 725d7ef..13f8e7f 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -242,9 +242,10 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
> * use STACK_TOP because that can depend on attributes which aren't
> * configured yet.
> */
> + BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);

Can we use BUILD_BUG_ON()?

but anyway
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: KOSAKI Motohiro on 12 May 2010 19:10
> On Wed, May 12, 2010 at 12:54:27PM -0700, Andrew Morton wrote:
> > On Wed, 12 May 2010 09:23:44 +0900 (JST)
> > KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> wrote:
> >
> > > > diff --git a/fs/exec.c b/fs/exec.c
> > > > index 725d7ef..13f8e7f 100644
> > > > --- a/fs/exec.c
> > > > +++ b/fs/exec.c
> > > > @@ -242,9 +242,10 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
> > > > * use STACK_TOP because that can depend on attributes which aren't
> > > > * configured yet.
> > > > */
> > > > + BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
> > >
> > > Can we use BUILD_BUG_ON()?
> >
> > That's vastly preferable - I made that change.
>
> I will be surprised if it works. On x86, that is
>
> #define VM_STACK_FLAGS (VM_GROWSDOWN | VM_STACK_DEFAULT_FLAGS | VM_ACCOUNT)
> #define VM_STACK_DEFAULT_FLAGS VM_DATA_DEFAULT_FLAGS
> #define VM_DATA_DEFAULT_FLAGS \
> (((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0 ) | \
> VM_READ | VM_WRITE | VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>
> so VM_STACK_FLAGS is depending on the value of current->personality
> which we don't know at build time.

Argh, yes right you are.

sorry for the noise.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] Disable i8042 checks on Intel Apple Macs
Next: [PATCH 1/4] MFD: pcf50633: Fix bitfield logic in interrupt handler