mmc: drop the "state" argument to mmc_suspend_host()
in [Kernel]
|
Prev: [PATCH 2/3] tty: Fix unbalanced BKL handling in error path
Next: [PATCH 1/3] serial: mpc52xx_uart: fix null pointer dereference
From: Anton Vorontsov on 13 May 2010 15:20 On Thu, May 13, 2010 at 08:01:45PM +0100, Matt Fleming wrote: > Even though many mmc host drivers pass a pm_message_t argument to > mmc_suspend_host() that argument isn't used the by MMC core. As host > drivers are converted to dev_pm_ops they'll have to construct > pm_message_t's (as they won't be passed by the PM subsystem any more) > just to appease the mmc suspend interface. > > We might as well just delete the unused paramter. > > Signed-off-by: Matt Fleming <matt(a)console-pimps.org> For sdhci-of* Acked-by: Anton Vorontsov <cbouatmailru(a)gmail.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michał Mirosław on 13 May 2010 17:50 On Thu, May 13, 2010 at 08:01:45PM +0100, Matt Fleming wrote: > Even though many mmc host drivers pass a pm_message_t argument to > mmc_suspend_host() that argument isn't used the by MMC core. As host > drivers are converted to dev_pm_ops they'll have to construct > pm_message_t's (as they won't be passed by the PM subsystem any more) > just to appease the mmc suspend interface. > > We might as well just delete the unused paramter. > > Signed-off-by: Matt Fleming <matt(a)console-pimps.org> Acked-by: Micha� Miros�aw <mirq-linux(a)rere.qmqm.pl> (For cb710-mmc part.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Harald Welte on 14 May 2010 06:30 On Thu, May 13, 2010 at 08:01:45PM +0100, Matt Fleming wrote: > Even though many mmc host drivers pass a pm_message_t argument to > mmc_suspend_host() that argument isn't used the by MMC core. As host > drivers are converted to dev_pm_ops they'll have to construct > pm_message_t's (as they won't be passed by the PM subsystem any more) > just to appease the mmc suspend interface. > > We might as well just delete the unused paramter. > > Signed-off-by: Matt Fleming <matt(a)console-pimps.org> for via-sdmmc: Acked-by: Harald Welte <laforge(a)gnumonks.org> -- - Harald Welte <HaraldWelte(a)viatech.com> http://linux.via.com.tw/ ============================================================================ VIA Free and Open Source Software Liaison -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Sascha Sommer on 16 May 2010 14:20
Hi, Am Donnerstag 13 Mai 2010 21:01:45 schrieb Matt Fleming: > Even though many mmc host drivers pass a pm_message_t argument to > mmc_suspend_host() that argument isn't used the by MMC core. As host > drivers are converted to dev_pm_ops they'll have to construct > pm_message_t's (as they won't be passed by the PM subsystem any more) > just to appease the mmc suspend interface. > > We might as well just delete the unused paramter. > > Signed-off-by: Matt Fleming <matt(a)console-pimps.org> Acked-by: Sascha Sommer <saschasommer(a)freenet.de> (for sdricoh_cs) Regards Sascha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |