Prev: [RFC] lp_events: an lternitive to suspend blocker user mode and kernel API
Next: [PATCH 3/5] oom: Fix child process iteration properly
From: Américo Wang on 1 Jun 2010 01:40
On Mon, May 31, 2010 at 09:31:42PM +0930, Rusty Russell wrote:
>@@ -783,9 +787,13 @@ SYSCALL_DEFINE2(delete_module, const cha
> /* Store the name of the last unloaded module for diagnostic purposes */
> strlcpy(last_unloaded_module, mod->name, sizeof(last_unloaded_module));
> ddebug_remove_module(mod->name);
>+
>+ /* free_module doesn't want module_mutex held by caller. */
>+ mutex_unlock(&module_mutex);
> free_module(mod);
>-
>- out:
>+ goto out_stop;

As Stephen found in linux-next, this line doesn't pass compiling.
I think this line should be just deleted.

>+
>+out:
> mutex_unlock(&module_mutex);
> return ret;
> }


Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Rusty Russell on 1 Jun 2010 02:00
On Tue, 1 Jun 2010 03:08:42 pm Am�rico Wang wrote:
> On Mon, May 31, 2010 at 09:31:42PM +0930, Rusty Russell wrote:
> >@@ -783,9 +787,13 @@ SYSCALL_DEFINE2(delete_module, const cha
> > /* Store the name of the last unloaded module for diagnostic purposes */
> > strlcpy(last_unloaded_module, mod->name, sizeof(last_unloaded_module));
> > ddebug_remove_module(mod->name);
> >+
> >+ /* free_module doesn't want module_mutex held by caller. */
> >+ mutex_unlock(&module_mutex);
> > free_module(mod);
> >-
> >- out:
> >+ goto out_stop;
>
> As Stephen found in linux-next, this line doesn't pass compiling.
> I think this line should be just deleted.

Yep, I didn't commit my fixes to the backport before pushing & posting;
I've done that now. You can get the usable one from the git tree:

git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6 modules

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [RFC] lp_events: an lternitive to suspend blocker user mode and kernel API
Next: [PATCH 3/5] oom: Fix child process iteration properly