Prev: [PATCH -mmotm 14/30] net: sk_allocation() - concentrate socket related allocations
Next: why is "struct cdev *cdev" in char_device_struct listed as "will die"?
From: Artem Bityutskiy on 13 Jul 2010 06:40
On Fri, 2010-07-02 at 00:12 +0200, Roel Kluin wrote:
> It should return -1 if the verify failed.
>
> Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com>
> ---
> I think this needed, correct?
>
> diff --git a/drivers/mtd/tests/mtd_pagetest.c b/drivers/mtd/tests/mtd_pagetest.c
> index 6bc1b82..7414888 100644
> --- a/drivers/mtd/tests/mtd_pagetest.c
> +++ b/drivers/mtd/tests/mtd_pagetest.c
> @@ -358,7 +358,7 @@ static int erasecrosstest(void)
> printk(PRINT_PREF "verify failed!\n");
> errcnt += 1;
> ok = 0;
> - return err;
> + return -1;
> }

Yeah, I changed your patch a bit and removed the 'ok' variable
altogether. Pushed to l2-mtd-2.6.git, please, check:

http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/4e2ef8529d9bc2e2b96f18a1a2917bda5475f0e4

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -mmotm 14/30] net: sk_allocation() - concentrate socket related allocations
Next: why is "struct cdev *cdev" in char_device_struct listed as "will die"?