net: Improve ks8851 snl transmit performance
in [Kernel]
|
Prev: tracing: Remove per event trace registering
Next: linux-next: manual merge of the omap_dss2 tree with the omap tree
From: Arce, Abraham on 7 May 2010 01:10 Hi, [snip] > There is a driver option no_tx_opt so that the driver can revert to original > implementation. This allows user to verify if the transmit performance > actually improves. Should we limit patch description to 80 characters also? > Signed-off-by: Tristram Ha <Tristram.Ha(a)micrel.com> > --- > This replaces the [patch 01/13] patch I submitted and was objected by David. > > Other users with Micrel KSZ8851 SNL chip please verify the transmit > performance does improve or not. Tested-by: Abraham Arce <x0066660(a)ti.com> Executing some nuttcp scenarios: - Without Patch - # /testsuites/ethernet/bin/nuttcp -u -i -Ri50m <serverip> 1.2676 MB / 1.00 sec = 10.6330 Mbps 0 / 1298 ~drop/pkt 0.00 ~%loss 1.2705 MB / 1.00 sec = 10.6579 Mbps 0 / 1301 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2695 MB / 1.00 sec = 10.6496 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss 1.2695 MB / 1.00 sec = 10.6496 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2646 MB / 1.00 sec = 10.6086 Mbps 0 / 1295 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6412 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2695 MB / 1.00 sec = 10.6498 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss 12.7314 MB / 10.02 sec = 10.6637 Mbps 4 %TX 0 %RX 0 / 13037 drop/pkt 0.00 %loss - With Patch - # /testsuites/ethernet/bin/nuttcp -u -i -Ri50m 10.87.231.229 1.2891 MB / 1.00 sec = 10.8133 Mbps 0 / 1320 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8217 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8217 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2910 MB / 1.00 sec = 10.8298 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss 1.2910 MB / 1.00 sec = 10.8299 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2891 MB / 1.00 sec = 10.8135 Mbps 0 / 1320 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2910 MB / 1.00 sec = 10.8298 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss 12.9492 MB / 10.02 sec = 10.8461 Mbps 4 %TX 0 %RX 0 / 13260 drop/pkt 0.00 %loss Also simulated heavy transmission consisting of 40 processes executed in parallel: - 20 ping instances using packet size of 32768 - 20 dd instances creating a 50MB file each under the nfs rootfs If any specific test scenario/application is required please do let me know... Best Regards Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ha, Tristram on 13 May 2010 01:50 I use a web browser to send patches through my company's e-mail system. The message is composed by cut and paste, so it may not conform to Linux standard. The latest nuttcp default size for UDP is 1500 bytes, rather than 8192 bytes. In my case, the transmit performance improves from 10 Mbps to 11. Have you tried TCP? -----Original Message----- From: Arce, Abraham [mailto:x0066660(a)ti.com] Sent: Thu 5/6/2010 10:02 PM To: Ha, Tristram; Ben Dooks Cc: David Miller; netdev(a)vger.kernel.org; linux-kernel(a)vger.kernel.org; Jan, Sebastien Subject: RE: [PATCH 2.6.34-rc6] net: Improve ks8851 snl transmit performance Hi, [snip] > There is a driver option no_tx_opt so that the driver can revert to original > implementation. This allows user to verify if the transmit performance > actually improves. Should we limit patch description to 80 characters also? > Signed-off-by: Tristram Ha <Tristram.Ha(a)micrel.com> > --- > This replaces the [patch 01/13] patch I submitted and was objected by David. > > Other users with Micrel KSZ8851 SNL chip please verify the transmit > performance does improve or not. Tested-by: Abraham Arce <x0066660(a)ti.com> Executing some nuttcp scenarios: - Without Patch - # /testsuites/ethernet/bin/nuttcp -u -i -Ri50m <serverip> 1.2676 MB / 1.00 sec = 10.6330 Mbps 0 / 1298 ~drop/pkt 0.00 ~%loss 1.2705 MB / 1.00 sec = 10.6579 Mbps 0 / 1301 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2695 MB / 1.00 sec = 10.6496 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss 1.2695 MB / 1.00 sec = 10.6496 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2646 MB / 1.00 sec = 10.6086 Mbps 0 / 1295 ~drop/pkt 0.00 ~%loss 1.2686 MB / 1.00 sec = 10.6412 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss 1.2695 MB / 1.00 sec = 10.6498 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss 12.7314 MB / 10.02 sec = 10.6637 Mbps 4 %TX 0 %RX 0 / 13037 drop/pkt 0.00 %loss - With Patch - # /testsuites/ethernet/bin/nuttcp -u -i -Ri50m 10.87.231.229 1.2891 MB / 1.00 sec = 10.8133 Mbps 0 / 1320 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8217 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8217 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2910 MB / 1.00 sec = 10.8298 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss 1.2910 MB / 1.00 sec = 10.8299 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2891 MB / 1.00 sec = 10.8135 Mbps 0 / 1320 ~drop/pkt 0.00 ~%loss 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss 1.2910 MB / 1.00 sec = 10.8298 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss 12.9492 MB / 10.02 sec = 10.8461 Mbps 4 %TX 0 %RX 0 / 13260 drop/pkt 0.00 %loss Also simulated heavy transmission consisting of 40 processes executed in parallel: - 20 ping instances using packet size of 32768 - 20 dd instances creating a 50MB file each under the nfs rootfs If any specific test scenario/application is required please do let me know... Best Regards Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arce, Abraham on 13 May 2010 19:50 Tristram, > The latest nuttcp default size for UDP is 1500 bytes, rather than 8192 bytes. > In my case, the transmit performance improves from 10 Mbps to 11. Have you > tried TCP? > Not yet... one point to highlight before: - SPI controller clock rate is 24 MHz, unable to set ~40 MHz, Now testing in 2.6.34 rc7 using now TCP, nuttcp version 6.1.2: Before the patch # /testsuites/ethernet/bin/nuttcp -i -Ri50m 10.87.231.229 1.1460 MB / 1.00 sec = 9.6134 Mbps 1.1858 MB / 1.00 sec = 9.9473 Mbps 1.2258 MB / 1.00 sec = 10.2828 Mbps 1.1996 MB / 1.00 sec = 10.0628 Mbps 1.2203 MB / 1.00 sec = 10.2365 Mbps 1.2258 MB / 1.00 sec = 10.2828 Mbps 1.2134 MB / 1.00 sec = 10.1786 Mbps 1.2235 MB / 1.00 sec = 10.2636 Mbps 1.2134 MB / 1.00 sec = 10.1785 Mbps 1.2120 MB / 1.00 sec = 10.1670 Mbps 12.6250 MB / 10.46 sec = 10.1240 Mbps 2 %TX 0 %RX 0 retrans 7.91 msRTT # /testsuites/ethernet/bin/nuttcp 10.87.231.229 12.9319 MB / 10.58 sec = 10.2553 Mbps 1 %TX 0 %RX 0 retrans 7.90 msRTT After the patch # /testsuites/ethernet/bin/nuttcp -i -Ri50m 10.87.231.229 1.1671 MB / 1.00 sec = 9.7902 Mbps 1.2169 MB / 1.00 sec = 10.2077 Mbps 1.2175 MB / 1.00 sec = 10.2134 Mbps 1.2396 MB / 1.00 sec = 10.3986 Mbps 1.2396 MB / 1.00 sec = 10.3987 Mbps 1.2387 MB / 1.00 sec = 10.3910 Mbps 1.2410 MB / 1.00 sec = 10.4102 Mbps 1.2203 MB / 1.00 sec = 10.2365 Mbps 1.2382 MB / 1.00 sec = 10.3871 Mbps 1.2369 MB / 1.00 sec = 10.3755 Mbps 12.8125 MB / 10.45 sec = 10.2820 Mbps 2 %TX 0 %RX 0 retrans 7.90 msRTT # /testsuites/ethernet/bin/nuttcp 10.87.231.229 13.0808 MB / 10.64 sec = 10.3123 Mbps 1 %TX 0 %RX 0 retrans 7.90 msRTT Best Regards Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Bill Fink on 14 May 2010 19:30 On Wed, 12 May 2010, Ha, Tristram wrote: > I use a web browser to send patches through my company's e-mail system. The message is composed by cut and paste, so it may not conform to Linux standard. > > The latest nuttcp default size for UDP is 1500 bytes, rather than 8192 bytes. In my case, the transmit performance improves from 10 Mbps to 11. Have you tried TCP? Just a nuttcp correction. The default unicast UDP buflen in any recent nuttcp is the largest power of 2 less than the MSS of the control connection. This means that the default UDP buflen for a 1500 byte MTU link is 1024, while for 9000 byte jumbo capable networks it would be 8192. This was done to avoid IP fragmentation by default in most common scenarios (can be overridden by explicitly setting the buflen with the "-l" nuttcp option). -Bill > -----Original Message----- > From: Arce, Abraham [mailto:x0066660(a)ti.com] > Sent: Thu 5/6/2010 10:02 PM > To: Ha, Tristram; Ben Dooks > Cc: David Miller; netdev(a)vger.kernel.org; linux-kernel(a)vger.kernel.org; Jan, Sebastien > Subject: RE: [PATCH 2.6.34-rc6] net: Improve ks8851 snl transmit performance > > Hi, > > [snip] > > > There is a driver option no_tx_opt so that the driver can revert to original > > implementation. This allows user to verify if the transmit performance > > actually improves. > > Should we limit patch description to 80 characters also? > > > Signed-off-by: Tristram Ha <Tristram.Ha(a)micrel.com> > > --- > > This replaces the [patch 01/13] patch I submitted and was objected by David. > > > > Other users with Micrel KSZ8851 SNL chip please verify the transmit > > performance does improve or not. > > Tested-by: Abraham Arce <x0066660(a)ti.com> > > Executing some nuttcp scenarios: > > - Without Patch - > > # /testsuites/ethernet/bin/nuttcp -u -i -Ri50m <serverip> > 1.2676 MB / 1.00 sec = 10.6330 Mbps 0 / 1298 ~drop/pkt 0.00 ~%loss > 1.2705 MB / 1.00 sec = 10.6579 Mbps 0 / 1301 ~drop/pkt 0.00 ~%loss > 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss > 1.2695 MB / 1.00 sec = 10.6496 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss > 1.2695 MB / 1.00 sec = 10.6496 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss > 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss > 1.2686 MB / 1.00 sec = 10.6414 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss > 1.2646 MB / 1.00 sec = 10.6086 Mbps 0 / 1295 ~drop/pkt 0.00 ~%loss > 1.2686 MB / 1.00 sec = 10.6412 Mbps 0 / 1299 ~drop/pkt 0.00 ~%loss > 1.2695 MB / 1.00 sec = 10.6498 Mbps 0 / 1300 ~drop/pkt 0.00 ~%loss > > 12.7314 MB / 10.02 sec = 10.6637 Mbps 4 %TX 0 %RX 0 / 13037 drop/pkt 0.00 %loss > > - With Patch - > > # /testsuites/ethernet/bin/nuttcp -u -i -Ri50m 10.87.231.229 > 1.2891 MB / 1.00 sec = 10.8133 Mbps 0 / 1320 ~drop/pkt 0.00 ~%loss > 1.2900 MB / 1.00 sec = 10.8217 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss > 1.2900 MB / 1.00 sec = 10.8217 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss > 1.2910 MB / 1.00 sec = 10.8298 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss > 1.2910 MB / 1.00 sec = 10.8299 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss > 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss > 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss > 1.2891 MB / 1.00 sec = 10.8135 Mbps 0 / 1320 ~drop/pkt 0.00 ~%loss > 1.2900 MB / 1.00 sec = 10.8216 Mbps 0 / 1321 ~drop/pkt 0.00 ~%loss > 1.2910 MB / 1.00 sec = 10.8298 Mbps 0 / 1322 ~drop/pkt 0.00 ~%loss > > 12.9492 MB / 10.02 sec = 10.8461 Mbps 4 %TX 0 %RX 0 / 13260 drop/pkt 0.00 > %loss > > Also simulated heavy transmission consisting of 40 processes executed in parallel: > > - 20 ping instances using packet size of 32768 > - 20 dd instances creating a 50MB file each under the nfs rootfs > > If any specific test scenario/application is required please do let me know... > > Best Regards > Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 16 May 2010 03:30
From: "Ha, Tristram" <Tristram.Ha(a)Micrel.Com> Date: Thu, 6 May 2010 15:50:27 -0700 > From: Tristram Ha <Tristram.Ha(a)micrel.com> > > Under heavy transmission the driver will put 4 1514-byte packets in > queue and stop the device transmit queue. Only the last packet > triggers the transmit done interrupt and wakes up the device > transmit queue. That means a bit of time is wasted when the CPU > cannot send any more packet. > > The new implementation triggers the transmit interrupt when the > transmit buffer left is less than 3 packets. The maximum transmit > buffer size is 6144 bytes. This allows the device transmit queue to > be restarted sooner so that CPU can send more packets. > > For TCP receiving it also has the benefit of not triggering any transmit interrupt at all. > > There is a driver option no_tx_opt so that the driver can revert to > original implementation. This allows user to verify if the transmit > performance actually improves. > > Signed-off-by: Tristram Ha <Tristram.Ha(a)micrel.com> First, if you want to post patches you have to format them properly as ascii text with no longer than 80 column lines in your commit message. I really don't want to hear about your email client being a reason you can't do this properly :-) Second, I don't think you can use the skb->ip_summed for this hacked state tracking you are using. The packet might be shared with other entities, and therefore if you change the field it won't be correct for them any more. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |