net/bridge: add support for EtherIP devices
in [Kernel]
|
Prev: New Intel feature flags.
Next: 2.6.18 BUG: unable to handle kernel NULL pointer dereference at virtual address 000,0000a
From: Stephen Hemminger on 24 Sep 2006 00:10 On Sat, 23 Sep 2006 14:16:29 +0200 Joerg Roedel <joro-lkml(a)zlug.org> wrote: > This patch changes the device check in the bridge code to allow EtherIP > devices to be added. > > Signed-off-by: Joerg Roedel <joro-lkml(a)zlug.org> If the device looks like a duck (Ethernet), then why does it need a separate ARP type. There are other tools that might work without modification if it just fully pretended to be an ether device. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joerg Roedel on 25 Sep 2006 04:30 On Sat, Sep 23, 2006 at 09:01:12PM -0700, Stephen Hemminger wrote: > If the device looks like a duck (Ethernet), then why does it need > a separate ARP type. There are other tools that might work without > modification if it just fully pretended to be an ether device. This solves the problem of getting a list of all EtherIP devices. If they use ARPHRD_ETHER and use an ioctl in the SIOCDEVPRIVATE space is not a save way (not even if the ioctl uses ethip0, this device could be owned by another driver if EtherIP is not present). On the other hand, a new ARP type opens a lot of new problems. A lot of userspace tools and libraries must be changed. So this solutions is not perfect. Cheers, Joerg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Stephen Hemminger on 25 Sep 2006 10:50 On Mon, 25 Sep 2006 10:24:45 +0200 Joerg Roedel <joro-lkml(a)zlug.org> wrote: > On Sat, Sep 23, 2006 at 09:01:12PM -0700, Stephen Hemminger wrote: > > > If the device looks like a duck (Ethernet), then why does it need > > a separate ARP type. There are other tools that might work without > > modification if it just fully pretended to be an ether device. > > This solves the problem of getting a list of all EtherIP devices. If > they use ARPHRD_ETHER and use an ioctl in the SIOCDEVPRIVATE space is > not a save way (not even if the ioctl uses ethip0, this device could be > owned by another driver if EtherIP is not present). > On the other hand, a new ARP type opens a lot of new problems. A lot of > userspace tools and libraries must be changed. So this solutions is not > perfect. > > Cheers, > Joerg To get a list of all EtherIP devices, just maintain a linked list in the private device information. Use list macros, it isn't hard. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joerg Roedel on 25 Sep 2006 11:00
On Mon, Sep 25, 2006 at 07:40:09AM -0700, Stephen Hemminger wrote: > > To get a list of all EtherIP devices, just maintain a linked list > in the private device information. Use list macros, it isn't hard. I use lists in the driver to maintain the list. The problem is to get such a list in userspace in a safe way (the way over SIOCDEVPRIVATE ioctls is not safe). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |