Prev: Property inquiry
Next: linux-next: build failure after merge of the xfs tree
From: David Miller on 25 Jul 2010 20:10
From: Bhavesh Davda <bhavesh(a)vmware.com>
Date: Sat, 24 Jul 2010 17:43:29 -0700

> ---

If you put the "---" there are the beginning of your message,
the whole commit message is discarded by GIT.

I said you should put "---" at the end of the commit message,
when you want to add more side commentary that should not appear
in the commit message but is for people in this thread to read.

I fixed this up when adding your patch, but I have no idea why
you did this. Please don't do it again.

> Fix an overflow bug in vmxnet3 Tx descriptor
>
> This patch fixes a bug where a 16K buffer on a Tx descriptor was overflowing
> into the 'gen' bit in the descriptor thereby corrupting the descriptor and
> stalling the transmit ring.
>
> Signed-off-by: Bhavesh Davda <bhavesh(a)vmware.com>
> Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com>
> Signed-off-by: Matthew Delco <delcoM(a)vmware.com>
> Signed-off-by: Ronghua Zhang <ronghua(a)vmware.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Bhavesh Davda on 26 Jul 2010 08:20
Sorry about that. I'll keep that in mind for future patches. Thanks for fixing up and commiting this patch.

Regards

- Bhavesh

(From my iPhone)


On Jul 25, 2010, at 5:05 PM, "David Miller" <davem(a)davemloft.net> wrote:

> From: Bhavesh Davda <bhavesh(a)vmware.com>
> Date: Sat, 24 Jul 2010 17:43:29 -0700
>
>> ---
>
> If you put the "---" there are the beginning of your message,
> the whole commit message is discarded by GIT.
>
> I said you should put "---" at the end of the commit message,
> when you want to add more side commentary that should not appear
> in the commit message but is for people in this thread to read.
>
> I fixed this up when adding your patch, but I have no idea why
> you did this. Please don't do it again.
>
>> Fix an overflow bug in vmxnet3 Tx descriptor
>>
>> This patch fixes a bug where a 16K buffer on a Tx descriptor was overflowing
>> into the 'gen' bit in the descriptor thereby corrupting the descriptor and
>> stalling the transmit ring.
>>
>> Signed-off-by: Bhavesh Davda <bhavesh(a)vmware.com>
>> Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com>
>> Signed-off-by: Matthew Delco <delcoM(a)vmware.com>
>> Signed-off-by: Ronghua Zhang <ronghua(a)vmware.com>
>
> Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Property inquiry
Next: linux-next: build failure after merge of the xfs tree