net-next: vmxnet3 fixes [3/5] Initialize link state at probe time
in [Kernel]
|
Prev: net-next: vmxnet3 fixes [1/5] Spare skb to avoid starvation
Next: [PATCH 2.6.35-rc1] net-next: fix LRO feature update in vmxnet3
From: Shreyas Bhatewara on 15 Jul 2010 21:30 On Wed, 14 Jul 2010, David Miller wrote: > From: Shreyas Bhatewara <sbhatewara(a)vmware.com> > Date: Tue, 13 Jul 2010 17:48:55 -0700 (PDT) > > > > > Initialize vmxnet3 link state at probe time > > > > This change initializes the state of link at the time when driver is > > loaded. The ethtool output for 'link detected' and 'link speed' > > is thus valid even before the interface is brought up. > > > > Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com> > > You should never, ever, call netif_start_queue() on a device which has > not been brought up. > > But that is what this patch is doing. > I do not understand why you say so. vmxnet3_check_link() is called in probe() with affectTxQueue as false. Hence netif_start_queue() will not be called before device is brought up. vmxnet3_check_link() is again called with affectTxQueue as true in vmxnet3_activate_dev() after device was activated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Shreyas Bhatewara on 16 Jul 2010 04:00
On Thu, 15 Jul 2010, David Miller wrote: > From: Shreyas Bhatewara <sbhatewara(a)vmware.com> > Date: Thu, 15 Jul 2010 18:20:14 -0700 (PDT) > > > > > On Wed, 14 Jul 2010, David Miller wrote: > > > >> From: Shreyas Bhatewara <sbhatewara(a)vmware.com> > >> Date: Tue, 13 Jul 2010 17:48:55 -0700 (PDT) > >> > >> > > >> > Initialize vmxnet3 link state at probe time > >> > > >> > This change initializes the state of link at the time when driver is > >> > loaded. The ethtool output for 'link detected' and 'link speed' > >> > is thus valid even before the interface is brought up. > >> > > >> > Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com> > >> > >> You should never, ever, call netif_start_queue() on a device which has > >> not been brought up. > >> > >> But that is what this patch is doing. > >> > > > > I do not understand why you say so. vmxnet3_check_link() is called in > > probe() with affectTxQueue as false. Hence netif_start_queue() will not be > > called before device is brought up. > > vmxnet3_check_link() is again called with affectTxQueue as true in > > vmxnet3_activate_dev() after device was activated. > > Aha, I see how the logic works now. > > But still there is a problem with this patch, please remove the > driver version bump and resubmit. > > You should only version bump at the last patch in a series. > > Thanks. > --- Initialize vmxnet3 link state at probe time This change initializes the state of link at the time when driver is loaded. The ethtool output for 'link detected' and 'link speed' is thus valid even before the interface is brought up. Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 7792a44..1e31d40 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -130,7 +130,7 @@ vmxnet3_tq_stop(struct vmxnet3_tx_queue *tq, struct vmxnet3_adapter *adapter) * Check the link state. This may start or stop the tx queue. */ static void -vmxnet3_check_link(struct vmxnet3_adapter *adapter) +vmxnet3_check_link(struct vmxnet3_adapter *adapter, bool affectTxQueue) { u32 ret; @@ -143,14 +143,16 @@ vmxnet3_check_link(struct vmxnet3_adapter *adapter) if (!netif_carrier_ok(adapter->netdev)) netif_carrier_on(adapter->netdev); - vmxnet3_tq_start(&adapter->tx_queue, adapter); + if (affectTxQueue) + vmxnet3_tq_start(&adapter->tx_queue, adapter); } else { printk(KERN_INFO "%s: NIC Link is Down\n", adapter->netdev->name); if (netif_carrier_ok(adapter->netdev)) netif_carrier_off(adapter->netdev); - vmxnet3_tq_stop(&adapter->tx_queue, adapter); + if (affectTxQueue) + vmxnet3_tq_stop(&adapter->tx_queue, adapter); } } @@ -165,7 +167,7 @@ vmxnet3_process_events(struct vmxnet3_adapter *adapter) /* Check if link state has changed */ if (events & VMXNET3_ECR_LINK) - vmxnet3_check_link(adapter); + vmxnet3_check_link(adapter, true); /* Check if there is an error on xmit/recv queues */ if (events & (VMXNET3_ECR_TQERR | VMXNET3_ECR_RQERR)) { @@ -1947,7 +1949,7 @@ vmxnet3_activate_dev(struct vmxnet3_adapter *adapter) * Check link state when first activating device. It will start the * tx queue if the link is up. */ - vmxnet3_check_link(adapter); + vmxnet3_check_link(adapter, true); napi_enable(&adapter->napi); vmxnet3_enable_all_intrs(adapter); @@ -2549,6 +2551,7 @@ vmxnet3_probe_device(struct pci_dev *pdev, } set_bit(VMXNET3_STATE_BIT_QUIESCED, &adapter->state); + vmxnet3_check_link(adapter, false); atomic_inc(&devices_found); return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |